Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group streaming experimental apis #33878

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Group streaming experimental apis #33878

merged 3 commits into from
Feb 2, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 1, 2022

Move undocumented next/rsc and next/vitals to next/streaming. In the future next/streaming can contain streaming SSR related (including react server components) APIs together.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 1, 2022
@huozhi huozhi marked this pull request as ready for review February 1, 2022 21:38
@ijjk
Copy link
Member

ijjk commented Feb 1, 2022

Failing test suites

Commit: 276d0bc

test/integration/relay-analytics/test/index.test.js

  • Analytics relayer with exported method > Relays the data to user code
  • Analytics relayer with hook > Relays the data to user code
Expand output

● Analytics relayer with exported method › Relays the data to user code

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:41819/
=========================== logs ===========================
navigating to "http://localhost:41819/", waiting until "load"
============================================================

  110 |           if (!frame.payload.includes('pong')) {
  111 |             page
> 112 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
      |                    ^
  113 |               .catch(() => {})
  114 |           }
  115 |         }

  at Playwright.loadPage (lib/browsers/playwright.ts:112:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at Object.<anonymous> (integration/relay-analytics/test/index.test.js:58:25)

● Analytics relayer with hook › Relays the data to user code

page.goto: net::ERR_EMPTY_RESPONSE at http://localhost:40121/
=========================== logs ===========================
navigating to "http://localhost:40121/", waiting until "load"
============================================================

  110 |           if (!frame.payload.includes('pong')) {
  111 |             page
> 112 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
      |                    ^
  113 |               .catch(() => {})
  114 |           }
  115 |         }

  at Playwright.loadPage (lib/browsers/playwright.ts:112:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at Object.<anonymous> (integration/relay-analytics/test/index.test.js:58:25)

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Feb 2, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js group-streaming-api Change
buildDuration 15.6s 15.9s ⚠️ +356ms
buildDurationCached 4.1s 4.1s -7ms
nodeModulesSize 359 MB 359 MB ⚠️ +180 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js group-streaming-api Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.787 3.753 -0.03
/ avg req/sec 660.09 666.2 +6.11
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.72 1.718 0
/error-in-render avg req/sec 1453.69 1455.3 +1.61
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary huozhi/next.js group-streaming-api Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB -1 B
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB -1 B
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js group-streaming-api Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js group-streaming-api Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.94 kB 4.94 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js group-streaming-api Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js group-streaming-api Change
index.html gzip 530 B 530 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓

Diffs

Diff for main-HASH.js 
@@ -474,8 +474,8 @@
       var _routeAnnouncer = __webpack_require__(8982);
       var _router1 = __webpack_require__(387);
       var _isError = __webpack_require__(676);
-      var _vitals = __webpack_require__(7813);
-      var _refresh = __webpack_require__(7739);
+      var _vitals = __webpack_require__(5834);
+      var _refresh = __webpack_require__(9831);
       function asyncGeneratorStep(
         gen,
         resolve,
@@ -2769,28 +2769,6 @@
       /***/
     },
 
-    /***/ 7739: /***/ function(
-      __unused_webpack_module,
-      exports,
-      __webpack_require__
-    ) {
-      "use strict";
-
-      Object.defineProperty(exports, "__esModule", {
-        value: true
-      });
-      exports.useRefreshRoot = useRefreshRoot;
-      exports.RefreshContext = void 0;
-      var _react = __webpack_require__(7294);
-      var RefreshContext = (0, _react).createContext(function(_) {});
-      exports.RefreshContext = RefreshContext;
-      function useRefreshRoot() {
-        return (0, _react).useContext(RefreshContext);
-      } //# sourceMappingURL=refresh.js.map
-
-      /***/
-    },
-
     /***/ 699: /***/ function(
       __unused_webpack_module,
       exports,
@@ -3147,7 +3125,29 @@
       /***/
     },
 
-    /***/ 7813: /***/ function(
+    /***/ 9831: /***/ function(
+      __unused_webpack_module,
+      exports,
+      __webpack_require__
+    ) {
+      "use strict";
+
+      Object.defineProperty(exports, "__esModule", {
+        value: true
+      });
+      exports.useRefreshRoot = useRefreshRoot;
+      exports.RefreshContext = void 0;
+      var _react = __webpack_require__(7294);
+      var RefreshContext = (0, _react).createContext(function(_) {});
+      exports.RefreshContext = RefreshContext;
+      function useRefreshRoot() {
+        return (0, _react).useContext(RefreshContext);
+      } //# sourceMappingURL=refresh.js.map
+
+      /***/
+    },
+
+    /***/ 5834: /***/ function(
       __unused_webpack_module,
       exports,
       __webpack_require__
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-6caeff1e2c61474a.js"
+      src="/_next/static/chunks/main-26728cc2321f9c30.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-6caeff1e2c61474a.js"
+      src="/_next/static/chunks/main-26728cc2321f9c30.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-6caeff1e2c61474a.js"
+      src="/_next/static/chunks/main-26728cc2321f9c30.js"
       defer=""
     ></script>
     <script
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js group-streaming-api Change
buildDuration 19.5s 20.1s ⚠️ +560ms
buildDurationCached 4.1s 4.1s -11ms
nodeModulesSize 359 MB 359 MB ⚠️ +180 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js group-streaming-api Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.748 3.78 ⚠️ +0.03
/ avg req/sec 667.06 661.4 ⚠️ -5.66
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.79 1.726 -0.06
/error-in-render avg req/sec 1396.83 1448.04 +51.21
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary huozhi/next.js group-streaming-api Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.4 kB 27.4 kB -1 B
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB -1 B
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js group-streaming-api Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js group-streaming-api Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.98 kB 4.98 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.21 kB 2.21 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js group-streaming-api Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary huozhi/next.js group-streaming-api Change
index.html gzip 531 B 530 B -1 B
link.html gzip 544 B 543 B -1 B
withRouter.html gzip 525 B 524 B -1 B
Overall change 1.6 kB 1.6 kB -3 B

Diffs

Diff for main-HASH.js 
@@ -474,8 +474,8 @@
       var _routeAnnouncer = __webpack_require__(8982);
       var _router1 = __webpack_require__(387);
       var _isError = __webpack_require__(676);
-      var _vitals = __webpack_require__(7813);
-      var _refresh = __webpack_require__(7739);
+      var _vitals = __webpack_require__(5834);
+      var _refresh = __webpack_require__(9831);
       function asyncGeneratorStep(
         gen,
         resolve,
@@ -2769,28 +2769,6 @@
       /***/
     },
 
-    /***/ 7739: /***/ function(
-      __unused_webpack_module,
-      exports,
-      __webpack_require__
-    ) {
-      "use strict";
-
-      Object.defineProperty(exports, "__esModule", {
-        value: true
-      });
-      exports.useRefreshRoot = useRefreshRoot;
-      exports.RefreshContext = void 0;
-      var _react = __webpack_require__(7294);
-      var RefreshContext = (0, _react).createContext(function(_) {});
-      exports.RefreshContext = RefreshContext;
-      function useRefreshRoot() {
-        return (0, _react).useContext(RefreshContext);
-      } //# sourceMappingURL=refresh.js.map
-
-      /***/
-    },
-
     /***/ 699: /***/ function(
       __unused_webpack_module,
       exports,
@@ -3147,7 +3125,29 @@
       /***/
     },
 
-    /***/ 7813: /***/ function(
+    /***/ 9831: /***/ function(
+      __unused_webpack_module,
+      exports,
+      __webpack_require__
+    ) {
+      "use strict";
+
+      Object.defineProperty(exports, "__esModule", {
+        value: true
+      });
+      exports.useRefreshRoot = useRefreshRoot;
+      exports.RefreshContext = void 0;
+      var _react = __webpack_require__(7294);
+      var RefreshContext = (0, _react).createContext(function(_) {});
+      exports.RefreshContext = RefreshContext;
+      function useRefreshRoot() {
+        return (0, _react).useContext(RefreshContext);
+      } //# sourceMappingURL=refresh.js.map
+
+      /***/
+    },
+
+    /***/ 5834: /***/ function(
       __unused_webpack_module,
       exports,
       __webpack_require__
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-6caeff1e2c61474a.js"
+      src="/_next/static/chunks/main-26728cc2321f9c30.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-6caeff1e2c61474a.js"
+      src="/_next/static/chunks/main-26728cc2321f9c30.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-6caeff1e2c61474a.js"
+      src="/_next/static/chunks/main-26728cc2321f9c30.js"
       defer=""
     ></script>
     <script
Commit: 18c3ea0

@kodiakhq kodiakhq bot merged commit 5365f41 into vercel:canary Feb 2, 2022
@huozhi huozhi deleted the group-streaming-api branch February 3, 2022 12:00
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@huozhi @natew
Group streaming experimental apis (vercel#33878)
a981267 
Move undocumented `next/rsc` and `next/vitals` to `next/streaming`. In the future `next/streaming` can contain streaming SSR related (including react server components) APIs together.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huozhi @ijjk @shuding