Add check for resolveWeak to next/dynamic

[timneutkens]

Fixes #33476

I've added the test for this but it passes either way, even when the change to loadable.js is not made. On the reproduction I was able to reproduce it consistently and it's fixed with this change.

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

Documentation / Examples

• Make sure the linting passes by running yarn lint

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
buildDuration	15.5s	15.4s	-95ms
buildDurationCached	6s	6s	-39ms
nodeModulesSize	359 MB	359 MB	⚠️ +245 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.168	3.189	⚠️ +0.02
/ avg req/sec	789.26	783.83	⚠️ -5.43
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.323	1.328	⚠️ +0.01
/error-in-render avg req/sec	1889.17	1882.67	⚠️ -6.5

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	27.5 kB	27.5 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.2 kB	71.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.57 kB	2.57 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	5.01 kB	5.01 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.26 kB	2.26 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.7 kB	14.7 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Diffs

Diff for _buildManifest.js

@@ -8,7 +8,7 @@ self.__BUILD_MANIFEST = {
     "static\u002Fchunks\u002Fpages\u002Fcss-97182c5b8324021a.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-b49fdb7088c2e39d.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-d871c798afae7091.js"
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-538d621a0e670391.js"],

Diff for dynamic-HASH.js

@@ -375,7 +375,11 @@
         }
         // Client only
         if (!initialized && "object" !== "undefined" && !opts.suspense) {
-          var moduleIds = opts.webpack ? opts.webpack() : opts.modules;
+          // require.resolveWeak check is needed for environments that don't have it available like Jest
+          var moduleIds =
+            opts.webpack && "function" === "function"
+              ? opts.webpack()
+              : opts.modules;
           if (moduleIds) {
             READY_INITIALIZERS.push(function(ids) {
               var _iteratorNormalCompletion = true,

---

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
buildDuration	19s	19s	-4ms
buildDurationCached	6s	6s	-13ms
nodeModulesSize	359 MB	359 MB	⚠️ +245 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.177	3.196	⚠️ +0.02
/ avg req/sec	786.93	782.22	⚠️ -4.71
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.319	1.321	0
/error-in-render avg req/sec	1896.06	1892.09	⚠️ -3.97

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.1 kB	42.1 kB	✓
main-HASH.js gzip	27.5 kB	27.5 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.3 kB	71.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.56 kB	2.56 kB	⚠️ +3 B
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	5.05 kB	5.05 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.28 kB	2.28 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.7 kB	14.7 kB	⚠️ +3 B

Client Build Manifests Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
_buildManifest.js gzip	460 B	459 B	-1 B
Overall change	460 B	459 B	-1 B

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/jest-next-dynamic	Change
index.html gzip	533 B	533 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.61 kB	1.61 kB	✓

Diffs

Diff for _buildManifest.js

@@ -8,7 +8,7 @@ self.__BUILD_MANIFEST = {
     "static\u002Fchunks\u002Fpages\u002Fcss-97182c5b8324021a.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-b49fdb7088c2e39d.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-d871c798afae7091.js"
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-538d621a0e670391.js"],

Diff for dynamic-HASH.js

@@ -375,7 +375,11 @@
         }
         // Client only
         if (!initialized && "object" !== "undefined" && !opts.suspense) {
-          var moduleIds = opts.webpack ? opts.webpack() : opts.modules;
+          // require.resolveWeak check is needed for environments that don't have it available like Jest
+          var moduleIds =
+            opts.webpack && "function" === "function"
+              ? opts.webpack()
+              : opts.modules;
           if (moduleIds) {
             READY_INITIALIZERS.push(function(ids) {
               var _iteratorNormalCompletion = true,

Commit: 8ba8ccf