Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/stable swc compiler options #34074

Merged
merged 24 commits into from
Feb 10, 2022

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Feb 7, 2022

Mark some previously experimental swc compiler options as stable under a new compiler option

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@padmaia padmaia force-pushed the chore/stable-swc-compiler-options branch from 0988780 to a6118ef Compare February 8, 2022 20:49
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@padmaia padmaia force-pushed the chore/stable-swc-compiler-options branch from a6118ef to bd7bb08 Compare February 8, 2022 22:25
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@padmaia padmaia force-pushed the chore/stable-swc-compiler-options branch from 19c7915 to e4006db Compare February 9, 2022 17:58
@padmaia padmaia requested a review from styfle February 9, 2022 18:08
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

styfle
styfle previously approved these changes Feb 9, 2022
styfle
styfle previously approved these changes Feb 9, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 10, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
buildDuration 15.5s 15.3s -172ms
buildDurationCached 6s 6s -64ms
nodeModulesSize 359 MB 359 MB ⚠️ +6.88 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
/ failed reqs 0 0
/ total time (seconds) 3.001 2.993 -0.01
/ avg req/sec 833.03 835.22 +2.19
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.19 1.192 0
/error-in-render avg req/sec 2100.62 2097.64 ⚠️ -2.98
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
buildDuration 18.6s 18.6s ⚠️ +18ms
buildDurationCached 6s 6s -23ms
nodeModulesSize 359 MB 359 MB ⚠️ +6.88 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
/ failed reqs 0 0
/ total time (seconds) 2.976 2.975 0
/ avg req/sec 840.18 840.41 +0.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.189 1.19 0
/error-in-render avg req/sec 2102.25 2100.5 ⚠️ -1.75
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js chore/stable-swc-compiler-options Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 87b9eaa

@kodiakhq kodiakhq bot merged commit 01ee7e0 into vercel:canary Feb 10, 2022
Copy link
Member Author

@padmaia padmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[redacted]

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants