Fix functions manifest test #34092

shuding · 2022-02-08T13:24:56Z

We should remove .next after checking the manifest file here.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

test/integration/react-streaming-and-server-components/test/functions.js

ijjk · 2022-02-08T14:01:01Z

Failing test suites

Commit: 4df1cb0

yarn testheadless test/integration/react-streaming-and-server-components/test/index.test.js

Functions manifest build > should contain rsc paths in functions manifest

Expand output

● Functions manifest build › should contain rsc paths in functions manifest

expect(received).toBe(expected) // Object.is equality

Expected: undefined
Received: "web"

  36 |       expect(pageNames).toContain(path)
  37 |       // Runtime of page `/` is undefined since it's configured as nodejs.
> 38 |       expect(runtime).toBe(path === '/' ? undefined : 'web')
     |                       ^
  39 |       expect(files.every((f) => f.startsWith('server/'))).toBe(true)
  40 |     })
  41 |

  at forEach (integration/react-streaming-and-server-components/test/functions.js:38:23)
      at Array.forEach (<anonymous>)
  at Object.<anonymous> (integration/react-streaming-and-server-components/test/functions.js:34:11)
      at runMicrotasks (<anonymous>)

Read more about building and testing Next.js in contributing.md.

huozhi · 2022-02-08T14:16:54Z

test/integration/react-streaming-and-server-components/test/functions.js

@@ -9,13 +9,14 @@ import { nextBuild } from './utils'

 export default function (context) {
  it('should not generate functions manifest when filesystem API is not enabled', async () => {
+    // Make sure there is no existing functions manifest (caused by failed tests etc).
+    await fs.remove(join(context.appDir, '.next'))


maybe also clean the .next for next test since it fails now

ijjk · 2022-02-08T15:41:23Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	shuding/next.js shu/6e85	Change
buildDuration	19.8s	19.7s	-94ms
buildDurationCached	7.5s	7.6s	⚠️ +105ms
nodeModulesSize	359 MB	359 MB	-6 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	shuding/next.js shu/6e85	Change
/ failed reqs	0	0	✓
/ total time (seconds)	4.361	4.393	⚠️ +0.03
/ avg req/sec	573.22	569.06	⚠️ -4.16
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.161	2.092	-0.07
/error-in-render avg req/sec	1156.73	1195.13	+38.4

Client Bundles (main, webpack, commons)

	vercel/next.js canary	shuding/next.js shu/6e85	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	27.5 kB	27.5 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.2 kB	71.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	shuding/next.js shu/6e85	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	shuding/next.js shu/6e85	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.57 kB	2.57 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	5.01 kB	5.01 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.26 kB	2.26 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.7 kB	14.7 kB	✓

Client Build Manifests

	vercel/next.js canary	shuding/next.js shu/6e85	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	shuding/next.js shu/6e85	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	shuding/next.js shu/6e85	Change
buildDuration	24.5s	24.5s	-51ms
buildDurationCached	7.6s	7.5s	-70ms
nodeModulesSize	359 MB	359 MB	-6 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	shuding/next.js shu/6e85	Change
/ failed reqs	0	0	✓
/ total time (seconds)	4.353	4.315	-0.04
/ avg req/sec	574.29	579.33	+5.04
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.133	2.069	-0.06
/error-in-render avg req/sec	1171.82	1208.35	+36.53

Client Bundles (main, webpack, commons)

	vercel/next.js canary	shuding/next.js shu/6e85	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.1 kB	42.1 kB	✓
main-HASH.js gzip	27.5 kB	27.5 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.3 kB	71.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	shuding/next.js shu/6e85	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	shuding/next.js shu/6e85	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.56 kB	2.56 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	5.05 kB	5.05 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.28 kB	2.28 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.7 kB	14.7 kB	✓

Client Build Manifests

	vercel/next.js canary	shuding/next.js shu/6e85	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	shuding/next.js shu/6e85	Change
index.html gzip	533 B	533 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: a56bd75

We should remove `.next` after checking the manifest file here. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`

fix functions-manifest test

d62d19b

shuding requested review from huozhi, ijjk and timneutkens as code owners February 8, 2022 13:24

ijjk added the created-by: Next.js team PRs by the Next.js team. label Feb 8, 2022

huozhi reviewed Feb 8, 2022

View reviewed changes

test/integration/react-streaming-and-server-components/test/functions.js Show resolved Hide resolved

clean the build before starting

4df1cb0

huozhi previously approved these changes Feb 8, 2022

View reviewed changes

ijjk previously approved these changes Feb 8, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

huozhi reviewed Feb 8, 2022

View reviewed changes

fix test

4f2e361

shuding dismissed stale reviews from ijjk and huozhi via 4f2e361 February 8, 2022 14:38

huozhi approved these changes Feb 8, 2022

View reviewed changes

Merge branch 'canary' into shu/6e85

1145889

This comment has been minimized.

Sign in to view

Merge branch 'canary' into shu/6e85

a56bd75

kodiakhq bot merged commit dd7962d into vercel:canary Feb 8, 2022

github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix functions manifest test #34092

Fix functions manifest test #34092

shuding commented Feb 8, 2022

This comment has been minimized.

ijjk commented Feb 8, 2022

huozhi Feb 8, 2022

This comment has been minimized.

ijjk commented Feb 8, 2022

Fix functions manifest test #34092

Fix functions manifest test #34092

Conversation

shuding commented Feb 8, 2022

Bug

Feature

Documentation / Examples

This comment has been minimized.

ijjk commented Feb 8, 2022

Failing test suites

huozhi Feb 8, 2022

Choose a reason for hiding this comment

This comment has been minimized.

ijjk commented Feb 8, 2022

Stats from current PR