Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use react-dom/server.browser when reactRoot: true #34116

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Feb 9, 2022

Since we want to use the streaming renderer when reactRoot: true, we have to make sure we use the right server implementation too.

@ijjk ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Feb 9, 2022
@devknoll devknoll changed the title Fix: use react-dom/server.browser when reactRoot: true Fix: Use react-dom/server.browser when reactRoot: true Feb 9, 2022
@ijjk
Copy link
Member

ijjk commented Feb 9, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
buildDuration 15.4s 15.5s ⚠️ +78ms
buildDurationCached 6.1s 6.2s ⚠️ +69ms
nodeModulesSize 359 MB 359 MB -33 B
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
/ failed reqs 0 0
/ total time (seconds) 3.174 3.153 -0.02
/ avg req/sec 787.64 792.87 +5.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.373 1.376 0
/error-in-render avg req/sec 1820.45 1816.5 ⚠️ -3.95
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
buildDuration 19s 19.5s ⚠️ +521ms
buildDurationCached 6s 6.1s ⚠️ +149ms
nodeModulesSize 359 MB 359 MB -33 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
/ failed reqs 0 0
/ total time (seconds) 3.177 4.109 ⚠️ +0.93
/ avg req/sec 786.89 608.46 ⚠️ -178.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.376 1.375 0
/error-in-render avg req/sec 1816.56 1817.67 +1.11
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-fix-stream-with-react-root Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 2a543cf

@kodiakhq kodiakhq bot merged commit 3e60359 into vercel:canary Feb 9, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
)

Since we want to use the streaming renderer when `reactRoot: true`, we have to make sure we use the right server implementation too.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants