Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] add note to clarify use of Link when clearing preview cookies (issue #34129) #34142

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

mattyocode
Copy link
Contributor

Add note that explains the need to pass prefetch={false} to Link component to prevent clearing cookies accidentally
(responding to issue "Docs: potential preview-mode error on production build #34129").

Note as follows:

Note: If calling this route using Link component, you must pass in prefetch={false} to prevent calling clearPreviewData during prefetch.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • [ x] Make sure the linting passes by running yarn lint

Add note to 'Clear preview mode cookies' that explains the need to pass `prefetch={false}` to `Link` component to prevent clearing cookies accidentally.
(Docs: potential preview-mode error on production build vercel#34129)
@styfle styfle linked an issue Feb 9, 2022 that may be closed by this pull request
@kodiakhq kodiakhq bot merged commit 49fbbf4 into vercel:canary Feb 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: potential preview-mode error on production build
3 participants