Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure /index route is redirected correctly for docs #34206

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Ensure /index route is redirected correctly for docs #34206

merged 1 commit into from
Feb 10, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 10, 2022

This adds an additional redirect to ensure /index on the data-fetching doc is handled correctly since the first search result currently links to /index

Screen Shot 2022-02-10 at 4 33 17 PM

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk requested a review from molebox February 10, 2022 22:34
@ijjk ijjk changed the title Ensure /index route is redirected correctly Ensure /index route is redirected correctly for docs Feb 10, 2022
styfle
styfle approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@ijjk ijjk merged commit 4643f3c into vercel:canary Feb 10, 2022
@ijjk ijjk deleted the docs/overview-redirect branch February 10, 2022 22:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@molebox molebox Awaiting requested review from molebox

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @styfle