-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few touch-ups to the docs on web forms in Next #34286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Beyond the minor changes... - Added a warning that back-end validation is more secure - Fixed a RegEx that I'm damn-near sure is wrong. - Returned status codes in the first back-end serverless example - Added a link the user can click on to learn what a HTTP method is ## Changes that must be reviewed: - Does the `script` tag need explanation? I think all that needs to be said is that you can indeed use it in Next.JS, without much trouble.
mahmoud-moursy
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi,
padmaia and
leerob
as code owners
February 13, 2022 11:14
Repo refuses to clone on my end; I'm incapable of running |
Managed to get it sorted; passes the lint check! |
ijjk
reviewed
Feb 14, 2022
ijjk
reviewed
Feb 14, 2022
ijjk
reviewed
Feb 14, 2022
ijjk
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beyond the minor changes...
Changes that must be reviewed:
script
tag need explanation? I think all that needs to be said is that you can indeed use it in Next.JS, without much trouble.Documentation / Examples
yarn lint