Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error Handing section for ISR #34360

Merged
merged 5 commits into from
Feb 15, 2022

Conversation

amandeepmittal
Copy link
Contributor

@amandeepmittal amandeepmittal commented Feb 15, 2022

This PR adds and updates the Error Handling section for ISR based on Lee's work in the PR: #33585 and JJ's input in the same.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Closes: #33585

@amandeepmittal
Copy link
Contributor Author

@leerob I created a new PR following the sections you added in the PR here.

@amandeepmittal
Copy link
Contributor Author

@ijjk, based on your input on Lee's PR, I updated the code snippet. Please have a look 🙏

@ijjk
Copy link
Member

ijjk commented Feb 15, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
buildDuration 20.3s 19.9s -386ms
buildDurationCached 7.5s 7.5s -48ms
nodeModulesSize 367 MB 367 MB -88 B
Page Load Tests Overall increase ✓
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
/ failed reqs 0 0
/ total time (seconds) 4.138 4.133 0
/ avg req/sec 604.22 604.84 +0.62
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.041 2.009 -0.03
/error-in-render avg req/sec 1225.13 1244.28 +19.15
Client Bundles (main, webpack, commons)
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
buildDuration 23.7s 23.8s ⚠️ +92ms
buildDurationCached 7.3s 7.4s ⚠️ +144ms
nodeModulesSize 367 MB 367 MB -88 B
Page Load Tests Overall increase ✓
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
/ failed reqs 0 0
/ total time (seconds) 4.226 4.169 -0.06
/ avg req/sec 591.55 599.71 +8.16
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.099 2.106 ⚠️ +0.01
/error-in-render avg req/sec 1190.91 1186.93 ⚠️ -3.98
Client Bundles (main, webpack, commons)
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary amandeepmittal/next.js update-isr-error-handling Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 5cb06ac

@ijjk ijjk merged commit 634926d into vercel:canary Feb 15, 2022
@amandeepmittal amandeepmittal deleted the update-isr-error-handling branch February 15, 2022 20:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants