-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve opening a new issue flow #34434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balazsorban44
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi and
padmaia
as code owners
February 16, 2022 15:59
styfle
reviewed
Feb 16, 2022
styfle
reviewed
Feb 16, 2022
styfle
reviewed
Feb 16, 2022
styfle
reviewed
Feb 16, 2022
styfle
reviewed
Feb 16, 2022
styfle
reviewed
Feb 16, 2022
styfle
reviewed
Feb 16, 2022
styfle
reviewed
Feb 16, 2022
This comment has been minimized.
This comment has been minimized.
Failing test suitesCommit: a5eb321
Expand output● next/jest › should work
● Test suite failed to run
Read more about building and testing Next.js in contributing.md. |
styfle
previously approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
ijjk
reviewed
Feb 16, 2022
ijjk
reviewed
Feb 16, 2022
This was referenced Feb 19, 2022
This was referenced Feb 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: Slack thread
When opening a new issue, it is desired that the user has checked if the
canary
release not already have fixed their issue, since we do not backport fixes to previous Next.js versions.next info
runs that looks like this:This links to a message docs page with more information and some useful links.
refactored our bug report templates to be more clear and removed the fields that are now unnecessary (since running
next info
is expected to run on releases that already have it)Made browser/deployment optional, as in most cases those fields are irrelevant. We still ask them, but mention that they are only needed if relevant.
Asking for the exact browser version now
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
yarn lint