Make concurrent features independent from the global runtime option #35245

shuding · 2022-03-11T09:54:56Z

This PR depends on #35242 and #35243. It allows the global runtime to be unset, as well as enables static optimization for Fizz and RSC pages in the Node.js runtime. Currently for the Edge runtime pages are still always SSR'd.

Closes #31317.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

packages/next/build/index.ts

test/integration/react-streaming-and-server-components/test/switchable-runtime.test.js

huozhi

Maybe we should have another testing app for testing per-page runtime only, the comments are pretty minor thing we can update in later PRs

packages/next/server/next-server.ts

ijjk · 2022-03-16T12:04:57Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	shuding/next.js shu/c393	Change
buildDuration	15.4s	15.2s	-185ms
buildDurationCached	6.3s	6s	-249ms
nodeModulesSize	456 MB	456 MB	⚠️ +1.73 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	shuding/next.js shu/c393	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.959	2.953	-0.01
/ avg req/sec	844.8	846.47	+1.67
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.161	1.176	⚠️ +0.01
/error-in-render avg req/sec	2153.19	2125.68	⚠️ -27.51

Client Bundles (main, webpack)

	vercel/next.js canary	shuding/next.js shu/c393	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28 kB	28 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.6 kB	71.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	shuding/next.js shu/c393	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	shuding/next.js shu/c393	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	192 B	192 B	✓
amp-HASH.js gzip	309 B	309 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.57 kB	2.57 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.48 kB	5.48 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.26 kB	2.26 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.2 kB	15.2 kB	✓

Client Build Manifests

	vercel/next.js canary	shuding/next.js shu/c393	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	shuding/next.js shu/c393	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	shuding/next.js shu/c393	Change
buildDuration	18.7s	18.6s	-12ms
buildDurationCached	6s	6.1s	⚠️ +100ms
nodeModulesSize	456 MB	456 MB	⚠️ +1.73 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	shuding/next.js shu/c393	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.943	2.963	⚠️ +0.02
/ avg req/sec	849.47	843.8	⚠️ -5.67
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.192	1.184	-0.01
/error-in-render avg req/sec	2096.68	2110.72	+14.04

Client Bundles (main, webpack)

	vercel/next.js canary	shuding/next.js shu/c393	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.2 kB	28.2 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.1 kB	72.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	shuding/next.js shu/c393	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	shuding/next.js shu/c393	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	313 B	313 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	2.56 kB	2.56 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	921 B	921 B	✓
image-HASH.js gzip	5.59 kB	5.59 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.33 kB	2.33 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	388 B	388 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.3 kB	15.3 kB	✓

Client Build Manifests

	vercel/next.js canary	shuding/next.js shu/c393	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	shuding/next.js shu/c393	Change
index.html gzip	530 B	530 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 6daf580

…option (#35245)" This reverts commit 853442d.

…option" (#35405) Reverts #35245

…zz (#35407) We should use the `hasConcurrentFeatures` as the condition to enable Fizz, instead of reactRoot, otherwise just by installing React 18 will break stuff such as CSS imports. Currently `hasConcurrentFeatures` still needs to opt-in via the global `runtime` option. Once we fixed all the CSS bugs and add back #35245, we can flip the condition here again. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`

make concurrent features independent from the global runtime option

98af4de

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 11, 2022

shuding added 3 commits March 11, 2022 18:16

Merge branch 'canary' into shu/c393

63f1f3d

add test

90f4e79

add more tests

ff5c71a

shuding force-pushed the shu/c393 branch from 9f8b3d0 to ff5c71a Compare March 11, 2022 22:45

shuding added 2 commits March 11, 2022 23:46

Merge branch 'canary' into shu/c393

1156601

fix linter errors

373747a

This comment has been minimized.

Sign in to view

shuding marked this pull request as ready for review March 11, 2022 23:08

shuding requested review from timneutkens, ijjk, padmaia and huozhi as code owners March 11, 2022 23:08

Merge branch 'canary' into shu/c393

bb62c2f

This comment has been minimized.

Sign in to view

shuding added 3 commits March 14, 2022 22:51

fix missing server components

5216611

fix tests

63d9a23

fix type errors

894c95e

This comment has been minimized.

Sign in to view

shuding added 4 commits March 15, 2022 20:03

fix test

db56044

fix tests

2af0804

use skip test

9d59dcc

Merge branch 'canary' into shu/c393

a284b88

This comment has been minimized.

Sign in to view

huozhi reviewed Mar 16, 2022

View reviewed changes

huozhi previously approved these changes Mar 16, 2022

View reviewed changes

kodiakhq bot and others added 2 commits March 16, 2022 10:31

Merge branch 'canary' into shu/c393

2064be6

remove comments

4ecc43a

huozhi dismissed their stale review via 4ecc43a March 16, 2022 10:33

huozhi reviewed Mar 16, 2022

View reviewed changes

packages/next/server/next-server.ts Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

shuding added 2 commits March 16, 2022 12:46

remove try-catch wrapper for loading flight manifest

2a46247

Merge branch 'canary' into shu/c393

6daf580

shuding requested a review from huozhi March 16, 2022 11:47

huozhi approved these changes Mar 16, 2022

View reviewed changes

kodiakhq bot merged commit 853442d into vercel:canary Mar 16, 2022

shuding deleted the shu/c393 branch March 16, 2022 12:13

shuding added a commit that referenced this pull request Mar 17, 2022

Revert "Make concurrent features independent from the global runtime …

201c7cf

…option (#35245)" This reverts commit 853442d.

shuding mentioned this pull request Mar 17, 2022

Revert "Make concurrent features independent from the global runtime option" #35405

Merged

kodiakhq bot pushed a commit that referenced this pull request Mar 17, 2022

Revert "Make concurrent features independent from the global runtime …

24f450e

…option" (#35405) Reverts #35245

shuding mentioned this pull request Mar 17, 2022

Use hasConcurrentFeatures instead of reactRoot as the condition of Fizz #35407

Merged

10 tasks

shuding mentioned this pull request Mar 21, 2022

Revert "Revert "Make concurrent features independent from the global runtime option" #35405" #35490

Merged

10 tasks

github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make concurrent features independent from the global runtime option #35245

Make concurrent features independent from the global runtime option #35245

shuding commented Mar 11, 2022 •

edited by huozhi

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

huozhi left a comment

This comment has been minimized.

ijjk commented Mar 16, 2022

Make concurrent features independent from the global runtime option #35245

Make concurrent features independent from the global runtime option #35245

Conversation

shuding commented Mar 11, 2022 • edited by huozhi Loading

Bug

Feature

Documentation / Examples

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

huozhi left a comment

Choose a reason for hiding this comment

This comment has been minimized.

ijjk commented Mar 16, 2022

Stats from current PR

shuding commented Mar 11, 2022 •

edited by huozhi

Loading