Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-swc): embed target triple string #35416

Merged
merged 2 commits into from
Mar 19, 2022

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Mar 17, 2022

This PR straightly port over swc's target triple metadata (swc-project/swc#4058) into next-swc, mainly for the tracking purpose of usages.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 17, 2022

Failing test suites

Commit: 2c1346d

yarn testheadless test/production/next/jest/index.test.ts

  • next/jest > should work
Expand output

● next/jest › should work

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   6 |   let next: NextInstance
   7 |
>  8 |   beforeAll(async () => {
     |   ^
   9 |     next = await createNext({
  10 |       files: {
  11 |         'public/vercel.svg':

  at production/next/jest/index.test.ts:8:3
  at Object.<anonymous> (production/next/jest/index.test.ts:5:1)

● Test suite failed to run

TypeError: Cannot read property 'destroy' of undefined

  134 |     })
  135 |   })
> 136 |   afterAll(() => next.destroy())
      |                       ^
  137 |
  138 |   it('should work', async () => {
  139 |     const html = await renderViaHTTP(next.url, '/')

  at production/next/jest/index.test.ts:136:23

Read more about building and testing Next.js in contributing.md.

@ijjk

This comment has been minimized.

extern crate napi_build;

fn main() {
let out_dir = env::var("OUT_DIR").expect("Outdir should exist");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being set right now? Would it break the napi-rs builds?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it is being set by napi-rs, is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's set by cargo (https://doc.rust-lang.org/cargo/reference/environment-variables.html), as well as other env var in this
build script (TARGET).

OUT_DIR — If the package has a build script, this is set to the folder where the build script should place its output

TARGET — the target triple that is being compiled for. Native code should be compiled for this triple.

These env var should be set as long as build goes through cargo (napi-rs cli wraps cargo as well). If someone uses rustc directly to build package it'll cause compilation error, which is highly unlikely in next-swc's case.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 18, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
buildDuration 15.2s 15.2s -82ms
buildDurationCached 6.1s 6.1s -15ms
nodeModulesSize 456 MB 456 MB ⚠️ +399 B
Page Load Tests Overall increase ✓
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
/ failed reqs 0 0
/ total time (seconds) 2.931 2.977 ⚠️ +0.05
/ avg req/sec 853.01 839.79 ⚠️ -13.22
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.186 1.164 -0.02
/error-in-render avg req/sec 2108.18 2148.44 +40.26
Client Bundles (main, webpack)
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
buildDuration 18.5s 18.6s ⚠️ +155ms
buildDurationCached 6.1s 6s -80ms
nodeModulesSize 456 MB 456 MB ⚠️ +399 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
/ failed reqs 0 0
/ total time (seconds) 2.939 2.931 -0.01
/ avg req/sec 850.69 852.93 +2.24
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.181 1.183 0
/error-in-render avg req/sec 2116.59 2113.75 ⚠️ -2.84
Client Bundles (main, webpack)
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary kwonoj/next.js feat-embed-target-triple Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: bb9ad3b

@kodiakhq kodiakhq bot merged commit 9be56aa into vercel:canary Mar 19, 2022
@kwonoj kwonoj deleted the feat-embed-target-triple branch March 20, 2022 08:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants