Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: detect ESM by ast type #35627

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 27, 2022

Simplify the esmodule detection. If there's any import/exprt usage, it will return Module in ast.type otherwise Script when isModule is set to "unknown"

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 27, 2022
@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review March 27, 2022 07:57
@ijjk
Copy link
Member

ijjk commented Mar 28, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
buildDuration 15.2s 15.1s -57ms
buildDurationCached 6s 6s -15ms
nodeModulesSize 467 MB 467 MB -690 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
/ failed reqs 0 0
/ total time (seconds) 2.919 2.958 ⚠️ +0.04
/ avg req/sec 856.32 845.07 ⚠️ -11.25
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.181 1.163 -0.02
/error-in-render avg req/sec 2117.26 2148.89 +31.63
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
buildDuration 18.6s 18.5s -100ms
buildDurationCached 6s 6s -34ms
nodeModulesSize 467 MB 467 MB -690 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
/ failed reqs 0 0
/ total time (seconds) 2.944 2.942 0
/ avg req/sec 849.29 849.72 +0.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.168 1.178 ⚠️ +0.01
/error-in-render avg req/sec 2140.44 2122.24 ⚠️ -18.2
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js detect-esm-by-swc-module Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: c3364e8

@kodiakhq kodiakhq bot merged commit 4bfcf83 into vercel:canary Mar 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
@huozhi huozhi deleted the detect-esm-by-swc-module branch August 25, 2022 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants