-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(turbopack): always alias server-only
and client-only
#56760
Conversation
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
map: IndexMap<&'static str, String>, | ||
) { | ||
for (pattern, request) in map { | ||
import_map.insert_exact_alias(pattern, request_to_import_mapping(project_path, &request)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: since we're just reffing the request
string, can we use &'static str
instead of String
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was kinda "forward looking" as I'm using format!()
in #56675
Closes WEB-1773