-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): set COREPACK_ENABLE_STRICT: 0
for create-next-app tests
#56955
Merged
kodiakhq
merged 2 commits into
canary
from
fix-package-manager-test-corepack-strict-off
Oct 17, 2023
Merged
chore(test): set COREPACK_ENABLE_STRICT: 0
for create-next-app tests
#56955
kodiakhq
merged 2 commits into
canary
from
fix-package-manager-test-corepack-strict-off
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
styfle
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
October 17, 2023 19:36
ijjk
approved these changes
Oct 17, 2023
Failing test suitesCommit: c58b098
Expand output● with squoosh › dev support w/o next.config.js › should use cached image file when parameters are the same for animated gif
Read more about building and testing Next.js in contributing.md. |
Tests Passed |
huozhi
approved these changes
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think some of the runners are missing
yarn
globally installed so its attempting to install with corepack. But the default behavior of corepack is to use the repo version (pnpm in this case) so runningyarn
will error. This PR disables corepack strict mode to avoid that problem.