-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cna): make create-next-app
even smaller and faster
#58030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
the
create-next-app
Related to our CLI tool for quickly starting a new Next.js application.
label
Nov 4, 2023
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
SukkaW
changed the title
[WIP] refactor(cna): replace callback-based dns API w/ promise-based
refactor(cna): make Nov 4, 2023
create-next-app
even smaller
Tests Passed |
SukkaW
force-pushed
the
refactor-cna-1
branch
from
November 4, 2023 20:50
d73e6f9
to
7d22323
Compare
SukkaW
changed the title
refactor(cna): make
refactor(cna): make Nov 5, 2023
create-next-app
even smallercreate-next-app
even smaller and faster
styfle
reviewed
Jan 5, 2024
styfle
reviewed
Jan 5, 2024
styfle
reviewed
Jan 5, 2024
styfle
reviewed
Jan 5, 2024
styfle
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
SukkaW
force-pushed
the
refactor-cna-1
branch
from
January 11, 2024 02:44
8cd8239
to
ae1c96a
Compare
@styfle I just rebased the PR and fixed the conflicts inside the |
styfle
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks! 🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR further reduces the
create-next-app
installation size by another 80 KiB:dns
API usage withdns/promise
+ async/awaitgot
w/fetch
since Next.js andcreate-next-app
now target Node.js 18.17.0+Following these changes, the size of
dist/index.js
is now 536 KiB.