Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-next-app): bump prompts to v2.4.2 #59006

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

BlankParticle
Copy link
Contributor

This PR updates prompts to v2.4.2, it fixes a bug I found and I haven't seen any reports about it.

The Bug

Screencast.from.2023-11-28.17-58-41.webm

There was a bug in prompts where it didn't handle Home and End button correctly. It has been fixed in later version. I have updated prompts along with @types/prompts to latest available version which is v2.4.2.

@BlankParticle BlankParticle requested review from a team as code owners November 28, 2023 12:36
@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Nov 28, 2023
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijjk
Copy link
Member

ijjk commented Nov 28, 2023

Allow CI Workflow Run

  • approve CI run for commit: a810b34

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@BlankParticle
Copy link
Contributor Author

Hey 👋
it's been 2 weeks since I made this PR.
@ForsakenHarmony can you ping someone who can review this PR, so that this can be merged 🙃

@ijjk
Copy link
Member

ijjk commented Dec 12, 2023

Stats from current PR

Default Build
General
vercel/next.js canary BlankParticle/next.js cna-update-prompts Change
buildDuration 10.8s 10.9s ⚠️ +117ms
buildDurationCached 6.1s 6s N/A
nodeModulesSize 200 MB 200 MB
nextStartRea..uration (ms) 433ms 426ms N/A
Client Bundles (main, webpack)
vercel/next.js canary BlankParticle/next.js cna-update-prompts Change
170-HASH.js gzip 26.7 kB 26.7 kB N/A
199.HASH.js gzip 181 B 185 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 31.7 kB 31.6 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary BlankParticle/next.js cna-update-prompts Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary BlankParticle/next.js cna-update-prompts Change
_app-HASH.js gzip 195 B 194 B N/A
_error-HASH.js gzip 183 B 182 B N/A
amp-HASH.js gzip 501 B 501 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 255 B
head-HASH.js gzip 349 B 350 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 309 B N/A
script-HASH.js gzip 384 B 384 B
withRouter-HASH.js gzip 307 B 306 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.57 kB 1.57 kB
Client Build Manifests
vercel/next.js canary BlankParticle/next.js cna-update-prompts Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary BlankParticle/next.js cna-update-prompts Change
index.html gzip 530 B 527 B N/A
link.html gzip 543 B 540 B N/A
withRouter.html gzip 525 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary BlankParticle/next.js cna-update-prompts Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 146 kB 146 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary BlankParticle/next.js cna-update-prompts Change
middleware-b..fest.js gzip 627 B 622 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.4 kB 37.4 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary BlankParticle/next.js cna-update-prompts Change
app-page-exp...dev.js gzip 168 kB 168 kB
app-page-exp..prod.js gzip 94.1 kB 94.1 kB
app-page-tur..prod.js gzip 94.8 kB 94.8 kB
app-page-tur..prod.js gzip 89.4 kB 89.4 kB
app-page.run...dev.js gzip 138 kB 138 kB
app-page.run..prod.js gzip 88.7 kB 88.7 kB
app-route-ex...dev.js gzip 23.9 kB 23.9 kB
app-route-ex..prod.js gzip 16.6 kB 16.6 kB
app-route-tu..prod.js gzip 16.6 kB 16.6 kB
app-route-tu..prod.js gzip 16.2 kB 16.2 kB
app-route.ru...dev.js gzip 23.4 kB 23.4 kB
app-route.ru..prod.js gzip 16.2 kB 16.2 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.4 kB 49.4 kB
Overall change 930 kB 930 kB
Commit: dcd0600

@ijjk ijjk merged commit 9973770 into vercel:canary Dec 13, 2023
64 of 69 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants