Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for client-side router filtering #59293

Closed

Conversation

crisvergara
Copy link
Contributor

Tests for #47486 . Illustrates a collision that causes a hard navigation for a random page based on behavior we see in our private repository.

@ijjk
Copy link
Member

ijjk commented Dec 5, 2023

Allow CI Workflow Run

  • approve CI run for commit: e73139c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Dec 5, 2023

Failing test suites

Commit: e73139c

pnpm test test/unit/create-client-router-filter.test.ts

  • createClientRouterFilter > creates a filter that does not collide with wildly different path names
Expand output

● createClientRouterFilter › creates a filter that does not collide with wildly different path names

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true

  25 |         '/all-hardcovers/no-one-can-know-1511?category=current-features'
  26 |       )
> 27 |     ).toBe(false)
     |       ^
  28 |   })
  29 | })
  30 |

  at Object.toBe (unit/create-client-router-filter.test.ts:27:7)

Read more about building and testing Next.js in contributing.md.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this test case, included it in #60542

@ijjk ijjk closed this Jan 12, 2024
ijjk added a commit that referenced this pull request Jan 12, 2024
This updates our default error rate to be much more precise and reduce
false positives by increasing the default size of the client filter we
generate. We can afford to increase the default size as it compresses
extremely well and gives us more accurate navigations. This carries over
the failing test case from #59293
which showed one case of false positive in a smaller filter.

Closes: #47486

Closes NEXT-2070

---------

Co-authored-by: Cris Vergara <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants