Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix integration test workflow #59508

Merged
merged 2 commits into from
Dec 11, 2023
Merged

fix integration test workflow #59508

merged 2 commits into from
Dec 11, 2023

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Dec 11, 2023 •
edited
Loading

This was incorrectly setting the upper bound on the --group argument to our test runners (ie, 11/122), which was causing a lot of tests to be missed.

Closes NEXT-1851

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Dec 11, 2023
@ztanner ztanner marked this pull request as ready for review December 11, 2023 22:52
@ztanner ztanner requested review from a team as code owners December 11, 2023 22:52
@ztanner ztanner requested review from molebox and StephDietz and removed request for a team December 11, 2023 22:52
@ijjk
Copy link
Member

ijjk commented Dec 11, 2023 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 11, 2023 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js fix/integration-test-workflow Change
buildDuration 10.7s 10.4s N/A
buildDurationCached 6.1s 6s N/A
nodeModulesSize 200 MB 200 MB ✓
nextStartRea..uration (ms) 427ms 427ms ✓
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/integration-test-workflow Change
170-HASH.js gzip 26.7 kB 26.7 kB N/A
199.HASH.js gzip 181 B 185 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB ✓
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 240 B 241 B N/A
main-HASH.js gzip 31.7 kB 31.6 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/integration-test-workflow Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix/integration-test-workflow Change
_app-HASH.js gzip 195 B 194 B N/A
_error-HASH.js gzip 183 B 182 B N/A
amp-HASH.js gzip 501 B 501 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 255 B ✓
head-HASH.js gzip 349 B 350 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 309 B N/A
script-HASH.js gzip 384 B 384 B ✓
withRouter-HASH.js gzip 307 B 306 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 1.57 kB 1.57 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix/integration-test-workflow Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/integration-test-workflow Change
index.html gzip 530 B 527 B N/A
link.html gzip 542 B 540 B N/A
withRouter.html gzip 524 B 524 B ✓
Overall change 524 B 524 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix/integration-test-workflow Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 146 kB 146 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js fix/integration-test-workflow Change
middleware-b..fest.js gzip 627 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 37.4 kB 37.4 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 2.07 kB 2.07 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js fix/integration-test-workflow Change
app-page-exp...dev.js gzip 168 kB 168 kB ✓
app-page-exp..prod.js gzip 93.9 kB 93.9 kB ✓
app-page-tur..prod.js gzip 94.7 kB 94.7 kB ✓
app-page-tur..prod.js gzip 89.2 kB 89.2 kB ✓
app-page.run...dev.js gzip 138 kB 138 kB ✓
app-page.run..prod.js gzip 88.5 kB 88.5 kB ✓
app-route-ex...dev.js gzip 23.9 kB 23.9 kB ✓
app-route-ex..prod.js gzip 16.6 kB 16.6 kB ✓
app-route-tu..prod.js gzip 16.6 kB 16.6 kB ✓
app-route-tu..prod.js gzip 16.2 kB 16.2 kB ✓
app-route.ru...dev.js gzip 23.4 kB 23.4 kB ✓
app-route.ru..prod.js gzip 16.2 kB 16.2 kB ✓
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB ✓
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 22.5 kB 22.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 49.4 kB 49.4 kB ✓
Overall change 929 kB 929 kB ✓
Commit: 7d25f18

@ztanner ztanner force-pushed the fix/integration-test-workflow branch from 84ddb1d to 7d25f18 Compare December 11, 2023 23:14
@ztanner ztanner merged commit bd5157c into canary Dec 11, 2023
64 of 69 checks passed
@ztanner ztanner deleted the fix/integration-test-workflow branch December 11, 2023 23:33
@ztanner ztanner mentioned this pull request Dec 12, 2023
Merged
ztanner added a commit that referenced this pull request Dec 12, 2023
@ztanner
fix NODE_OPTIONS=inspect (#59530)
b441cff 
Passing `NODE_OPTIONS='--inspect'` was failing because a sub-process was
getting created (`getRegistry()`) which would trigger a "address already
in use" error when the process inherited the same debugger port from the
parent process.

I had to disable this test in
#59508 because it wasn't passing,
CI was just skipping it. This PR fixes the behavior and re-enables the
test.

Fixes #55862

Closes NEXT-1854
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@molebox molebox Awaiting requested review from molebox molebox was automatically assigned from vercel/devex

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz was automatically assigned from vercel/devex

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ztanner @ijjk