Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not show no index for client rendering bailout #59531

Merged
merged 12 commits into from
Dec 13, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Dec 12, 2023

When a static page was built due to bailout to client rendering, like when using useSearchParams but without Suspense boundary wrapped on top of it. Since it's expected error on SSR, we don't render extra noindex in meta tags to avoid the page being indexed.

Update the test cases of useSearchparams hook into dynamic rendering and static-optimized cases:

  • dynanic case will not even have the error id or the meta tag
  • static-optimized case in production it won't have this meta tag

Closes NEXT-1853
Fixes #58615

@ijjk
Copy link
Member

ijjk commented Dec 12, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 12, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/no-index-search-params Change
buildDuration 10.9s 11s N/A
buildDurationCached 6s 6.3s ⚠️ +292ms
nodeModulesSize 200 MB 200 MB ⚠️ +4.53 kB
nextStartRea..uration (ms) 406ms 410ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/no-index-search-params Change
170-HASH.js gzip 26.7 kB 26.8 kB N/A
199.HASH.js gzip 181 B 185 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 241 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/no-index-search-params Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/no-index-search-params Change
_app-HASH.js gzip 195 B 194 B N/A
_error-HASH.js gzip 183 B 182 B N/A
amp-HASH.js gzip 501 B 501 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 255 B
head-HASH.js gzip 349 B 350 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 309 B N/A
script-HASH.js gzip 384 B 384 B
withRouter-HASH.js gzip 307 B 306 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.57 kB 1.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/no-index-search-params Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/no-index-search-params Change
index.html gzip 530 B 527 B N/A
link.html gzip 542 B 539 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix/no-index-search-params Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 146 kB 146 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js fix/no-index-search-params Change
middleware-b..fest.js gzip 627 B 622 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.4 kB 37.4 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary vercel/next.js fix/no-index-search-params Change
app-page-exp...dev.js gzip 168 kB 168 kB N/A
app-page-exp..prod.js gzip 94.1 kB 94.1 kB N/A
app-page-tur..prod.js gzip 94.8 kB 94.8 kB N/A
app-page-tur..prod.js gzip 89.4 kB 89.4 kB N/A
app-page.run...dev.js gzip 138 kB 138 kB N/A
app-page.run..prod.js gzip 88.7 kB 88.7 kB N/A
app-route-ex...dev.js gzip 23.9 kB 23.9 kB
app-route-ex..prod.js gzip 16.6 kB 16.6 kB
app-route-tu..prod.js gzip 16.6 kB 16.6 kB
app-route-tu..prod.js gzip 16.2 kB 16.2 kB
app-route.ru...dev.js gzip 23.4 kB 23.4 kB
app-route.ru..prod.js gzip 16.2 kB 16.2 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.4 kB 49.4 kB
Overall change 257 kB 257 kB
Diff details
Diff for page.js

Diff too large to display

Diff for 170-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Commit: f93c664

@huozhi huozhi changed the title Should not show no index for client rendering bailout (WIP) Should not show no index for client rendering bailout Dec 12, 2023
@huozhi huozhi changed the title (WIP) Should not show no index for client rendering bailout Should not show no index for client rendering bailout Dec 12, 2023
@huozhi huozhi marked this pull request as ready for review December 12, 2023 15:09
@huozhi huozhi requested a review from ztanner December 12, 2023 20:54
@huozhi huozhi merged commit 572a6bc into canary Dec 13, 2023
69 checks passed
@huozhi huozhi deleted the fix/no-index-search-params branch December 13, 2023 10:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of useSearchParams is causing the addition of meta robots with noindex in the production build
3 participants