fix(playwright): teardown when global quit force terminates browser #59548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While debugging some tests, tracing can be corrupted if it's short-lived single page navigation. It is due to we have global
quit
, which can be called in any context does not aware any teardown process is ongoing. This makes race condition while teardown is in progress browser instance being terminated, ends up having incorrect teardown state.For a stopgap workaround, creates another global to register any teardown to complete before quitting. In a long run should refactor the interface itself I think.
Closes PACK-2142