Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Convex Example #59789

Merged
merged 4 commits into from
Dec 28, 2023
Merged

Update Convex Example #59789

merged 4 commits into from
Dec 28, 2023

Conversation

ianmacartney
Copy link
Contributor

Updates the convex example to use a more recent version, along with newer style syntax and best practices.

Adding or Updating Examples

@ianmacartney ianmacartney requested review from a team as code owners December 20, 2023 02:56
@ianmacartney ianmacartney requested review from jh3y and molebox and removed request for a team December 20, 2023 02:56
@ijjk ijjk added the examples Issue/PR related to examples label Dec 20, 2023
@ianmacartney
Copy link
Contributor Author

I can't get info from those errors: is it just b/c this is on my personal org, not owned by next.js?

@leerob
Copy link
Member

leerob commented Dec 24, 2023

Looks like Prettier failed here 🙏

@ianmacartney
Copy link
Contributor Author

Very strange. That failing file was only touched by the merge commit. Rebasing w/o that merge commit and running pnpm lint passes without changing anything. ¯_(ツ)_/¯

examples/convex/README.md Outdated Show resolved Hide resolved
@leerob leerob merged commit 7343af9 into vercel:canary Dec 28, 2023
32 checks passed
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants