Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: opengraph / twitter image needs absolute URL #59985

Merged
merged 1 commit into from
Dec 28, 2023
Merged

docs: opengraph / twitter image needs absolute URL #59985

merged 1 commit into from
Dec 28, 2023

Conversation

leerob
Copy link
Member

@leerob leerob commented Dec 28, 2023

@leerob leerob requested review from a team as code owners December 28, 2023 04:45
@leerob leerob requested review from timeyoutakeit and delbaoliveira and removed request for a team December 28, 2023 04:45
@leerob leerob merged commit 548a07f into canary Dec 28, 2023
31 checks passed
@leerob leerob deleted the leerob-patch-2 branch December 28, 2023 04:48
@sanjaiyan-dev sanjaiyan-dev mentioned this pull request Dec 28, 2023
Merged
@AhmedBaset
Copy link
Contributor

AhmedBaset commented Dec 29, 2023 •
edited
Loading

Why isn't the metadataBase included before it automatically?

agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
@leerob @agustints
docs: opengraph / twitter image needs absolute URL (vercel#59985)
4237e77
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timeyoutakeit timeyoutakeit Awaiting requested review from timeyoutakeit timeyoutakeit was automatically assigned from vercel/devex

@delbaoliveira delbaoliveira Awaiting requested review from delbaoliveira delbaoliveira was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
created-by: Next.js Docs team PRs by the Docs team. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leerob @AhmedBaset @ijjk