Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting rid of a few TypeScript anys. #60017

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Getting rid of a few TypeScript anys. #60017

merged 4 commits into from
Jan 3, 2024

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Dec 29, 2023 •
edited
Loading

Had some spare time and was trying to get more familiar with the codebase.

Added a few types to create-next-app here. Nothing fancy!

@anthonyshew anthonyshew requested a review from a team as a code owner December 29, 2023 07:34
@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Dec 29, 2023
@ijjk
Copy link
Member

ijjk commented Dec 29, 2023 •
edited by styfle
Loading

Allow CI Workflow Run

  • approve CI run for commit: cab8dcc

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Dec 29, 2023 •
edited by styfle
Loading

Allow CI Workflow Run

  • approve CI run for commit: 326edbe

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

anthonyshew
anthonyshew commented Jan 3, 2024
View reviewed changes
packages/create-next-app/create-app.ts
} catch (error: any) {
if (error.code !== 'ERR_INVALID_URL') {
} catch (error: unknown) {
const err = error as Error & { code: string | undefined }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that casting is really any safer. 🤷 I suppose it's slightly closer to the truth this way.

@styfle styfle added the CI approved Approve running CI for fork label Jan 3, 2024
@ijjk
Copy link
Member

ijjk commented Jan 3, 2024

Stats from current PR

Default Build
General
vercel/next.js canary anthonyshew/next.js tighter-types-in-create-next-app Change
buildDuration 12.7s 12.8s N/A
buildDurationCached 7.2s 6.1s N/A
nodeModulesSize 202 MB 202 MB ✓
nextStartRea..uration (ms) 421ms 434ms N/A
Client Bundles (main, webpack)
vercel/next.js canary anthonyshew/next.js tighter-types-in-create-next-app Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB ✓
433-HASH.js gzip 28.4 kB 28.5 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 240 B 243 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary anthonyshew/next.js tighter-types-in-create-next-app Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary anthonyshew/next.js tighter-types-in-create-next-app Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.28 kB 4.28 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB ✓
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.4 kB 3.4 kB ✓
Client Build Manifests
vercel/next.js canary anthonyshew/next.js tighter-types-in-create-next-app Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary anthonyshew/next.js tighter-types-in-create-next-app Change
index.html gzip 528 B 527 B N/A
link.html gzip 540 B 540 B ✓
withRouter.html gzip 523 B 522 B N/A
Overall change 540 B 540 B ✓
Edge SSR bundle Size
vercel/next.js canary anthonyshew/next.js tighter-types-in-create-next-app Change
edge-ssr.js gzip 93.7 kB 93.8 kB N/A
page.js gzip 146 kB 147 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary anthonyshew/next.js tighter-types-in-create-next-app Change
middleware-b..fest.js gzip 624 B 624 B ✓
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 37.4 kB 37.4 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 2.7 kB 2.7 kB ✓
Next Runtimes
vercel/next.js canary anthonyshew/next.js tighter-types-in-create-next-app Change
app-page-exp...dev.js gzip 168 kB 168 kB ✓
app-page-exp..prod.js gzip 94.2 kB 94.2 kB ✓
app-page-tur..prod.js gzip 94.9 kB 94.9 kB ✓
app-page-tur..prod.js gzip 89.4 kB 89.4 kB ✓
app-page.run...dev.js gzip 138 kB 138 kB ✓
app-page.run..prod.js gzip 88.7 kB 88.7 kB ✓
app-route-ex...dev.js gzip 24.1 kB 24.1 kB ✓
app-route-ex..prod.js gzip 16.7 kB 16.7 kB ✓
app-route-tu..prod.js gzip 16.7 kB 16.7 kB ✓
app-route-tu..prod.js gzip 16.3 kB 16.3 kB ✓
app-route.ru...dev.js gzip 23.5 kB 23.5 kB ✓
app-route.ru..prod.js gzip 16.3 kB 16.3 kB ✓
pages-api-tu..prod.js gzip 9.38 kB 9.38 kB ✓
pages-api.ru...dev.js gzip 9.65 kB 9.65 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 22.5 kB 22.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 49.4 kB 49.4 kB ✓
Overall change 932 kB 932 kB ✓
Commit: 33829f3

@styfle styfle merged commit 5a10d25 into vercel:canary Jan 3, 2024
63 of 68 checks passed
@samcx samcx mentioned this pull request Jan 6, 2024
Closed
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
@anthonyshew @styfle @agustints
Getting rid of a few TypeScript anys. (vercel#60017)
1ca4c1a 
Had some spare time and was trying to get more familiar with the
codebase.

Added a few types to `create-next-app` here. Nothing fancy!

---------

Co-authored-by: Steven <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

Assignees
No one assigned
Labels
CI approved Approve running CI for fork create-next-app Related to our CLI tool for quickly starting a new Next.js application. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthonyshew @ijjk @styfle