Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip cron workflows on forks #60422

Merged
merged 6 commits into from
Jan 9, 2024
Merged

ci: skip cron workflows on forks #60422

merged 6 commits into from
Jan 9, 2024

Conversation

AhmedBaset
Copy link
Contributor

@AhmedBaset AhmedBaset commented Jan 9, 2024

This PR skips running cron workflows outside of vercel/next.js

@AhmedBaset AhmedBaset requested review from a team as code owners January 9, 2024 12:10
@AhmedBaset AhmedBaset requested review from manovotny and StephDietz and removed request for a team January 9, 2024 12:10
@ijjk
Copy link
Member

ijjk commented Jan 9, 2024

Allow CI Workflow Run

  • approve CI run for commit: 0e571d4

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Jan 9, 2024

Allow CI Workflow Run

  • approve CI run for commit: 0e571d4

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@AhmedBaset AhmedBaset changed the title ci: skip workflows on forks ci: skip cron workflows on forks Jan 9, 2024
@styfle styfle added the CI approved Approve running CI for fork label Jan 9, 2024
@styfle styfle enabled auto-merge (squash) January 9, 2024 14:12
@ijjk
Copy link
Member

ijjk commented Jan 9, 2024

Failing test suites

Commit: 862fa91

pnpm test-start test/e2e/prerender.test.ts

  • Prerender > should handle on-demand revalidate for fallback: blocking
Expand output

● Prerender › should handle on-demand revalidate for fallback: blocking

expect(received).toMatch(expected)

Expected pattern: /(HIT|STALE)/
Received string:  "MISS"

  2158 |           const $2 = cheerio.load(html2)
  2159 |
> 2160 |           expect(res2.headers.get(cacheHeader)).toMatch(/(HIT|STALE)/)
       |                                                 ^
  2161 |           expect(initialTime).toBe($2('#time').text())
  2162 |         }
  2163 |

  at Object.toMatch (e2e/prerender.test.ts:2160:49)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Jan 9, 2024

Stats from current PR

Default Build
General
vercel/next.js canary A7med3bdulBaset/next.js patch-13 Change
buildDuration 12.9s 13s N/A
buildDurationCached 7.2s 6.3s N/A
nodeModulesSize 199 MB 199 MB
nextStartRea..uration (ms) 423ms 449ms N/A
Client Bundles (main, webpack)
vercel/next.js canary A7med3bdulBaset/next.js patch-13 Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB N/A
433-HASH.js gzip 28.6 kB 28.6 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 239 B 242 B N/A
main-HASH.js gzip 31.7 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.2 kB 45.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary A7med3bdulBaset/next.js patch-13 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary A7med3bdulBaset/next.js patch-13 Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.28 kB 4.28 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary A7med3bdulBaset/next.js patch-13 Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary A7med3bdulBaset/next.js patch-13 Change
index.html gzip 527 B 527 B
link.html gzip 541 B 539 B N/A
withRouter.html gzip 523 B 522 B N/A
Overall change 527 B 527 B
Edge SSR bundle Size
vercel/next.js canary A7med3bdulBaset/next.js patch-13 Change
edge-ssr.js gzip 93.8 kB 93.8 kB N/A
page.js gzip 148 kB 148 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary A7med3bdulBaset/next.js patch-13 Change
middleware-b..fest.js gzip 622 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.4 kB 37.4 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary A7med3bdulBaset/next.js patch-13 Change
app-page-exp...dev.js gzip 169 kB 169 kB
app-page-exp..prod.js gzip 95.2 kB 95.2 kB
app-page-tur..prod.js gzip 95.8 kB 95.8 kB
app-page-tur..prod.js gzip 90.4 kB 90.4 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 89.8 kB 89.8 kB
app-route-ex...dev.js gzip 24.1 kB 24.1 kB
app-route-ex..prod.js gzip 16.7 kB 16.7 kB
app-route-tu..prod.js gzip 16.7 kB 16.7 kB
app-route-tu..prod.js gzip 16.3 kB 16.3 kB
app-route.ru...dev.js gzip 23.5 kB 23.5 kB
app-route.ru..prod.js gzip 16.3 kB 16.3 kB
pages-api-tu..prod.js gzip 9.38 kB 9.38 kB
pages-api.ru...dev.js gzip 9.65 kB 9.65 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.5 kB 49.5 kB
Overall change 939 kB 939 kB
Commit: dca4789

@styfle styfle merged commit 967784b into vercel:canary Jan 9, 2024
63 of 68 checks passed
ijjk pushed a commit that referenced this pull request Jan 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants