Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition some check calls in tests to retry #60489

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

wyattjoh
Copy link
Member

@wyattjoh wyattjoh commented Jan 10, 2024

Closes NEXT-2049

@wyattjoh
Copy link
Member Author

wyattjoh commented Jan 10, 2024

In this stack: 🌟 Improve Test Reliability and Performance

This stack of pull requests aims to enhance the reliability and performance of the tests by handling pages double render for useParams and transitioning some check calls to retry.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wyattjoh and the rest of your teammates on Graphite Graphite

@wyattjoh wyattjoh marked this pull request as ready for review January 10, 2024 19:43
@ijjk
Copy link
Member

ijjk commented Jan 10, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js feat/transition-checks-to-retries Change
buildDuration 14s 14.1s N/A
buildDurationCached 8s 7s N/A
nodeModulesSize 199 MB 199 MB
nextStartRea..uration (ms) 451ms 424ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js feat/transition-checks-to-retries Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB N/A
433-HASH.js gzip 28.5 kB 28.6 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.2 kB 45.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feat/transition-checks-to-retries Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js feat/transition-checks-to-retries Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.28 kB 4.28 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js feat/transition-checks-to-retries Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js feat/transition-checks-to-retries Change
index.html gzip 528 B 527 B N/A
link.html gzip 541 B 538 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js feat/transition-checks-to-retries Change
edge-ssr.js gzip 93.8 kB 93.8 kB N/A
page.js gzip 148 kB 148 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js feat/transition-checks-to-retries Change
middleware-b..fest.js gzip 624 B 624 B
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.5 kB 37.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.7 kB 2.7 kB
Next Runtimes
vercel/next.js canary vercel/next.js feat/transition-checks-to-retries Change
app-page-exp...dev.js gzip 169 kB 169 kB
app-page-exp..prod.js gzip 95.3 kB 95.3 kB
app-page-tur..prod.js gzip 96 kB 96 kB
app-page-tur..prod.js gzip 90.6 kB 90.6 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 89.9 kB 89.9 kB
app-route-ex...dev.js gzip 24.1 kB 24.1 kB
app-route-ex..prod.js gzip 16.7 kB 16.7 kB
app-route-tu..prod.js gzip 16.7 kB 16.7 kB
app-route-tu..prod.js gzip 16.3 kB 16.3 kB
app-route.ru...dev.js gzip 23.5 kB 23.5 kB
app-route.ru..prod.js gzip 16.3 kB 16.3 kB
pages-api-tu..prod.js gzip 9.38 kB 9.38 kB
pages-api.ru...dev.js gzip 9.65 kB 9.65 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.5 kB 49.5 kB
Overall change 940 kB 940 kB
Commit: b667353

@wyattjoh wyattjoh force-pushed the feat/transition-checks-to-retries branch from 72d8812 to 8487f84 Compare January 10, 2024 20:02
@wyattjoh
Copy link
Member Author

wyattjoh commented Jan 10, 2024

Merge activity

  • Jan 10, 3:19 PM: @wyattjoh started a stack merge that includes this pull request via Graphite.
  • Jan 10, 3:20 PM: Graphite rebased this pull request as part of a merge.
  • Jan 10, 3:41 PM: Graphite couldn't merge this PR because it was not satisfying all requirements.

Base automatically changed from tests/handle-hydration-render-case to canary January 10, 2024 20:19
@wyattjoh wyattjoh force-pushed the feat/transition-checks-to-retries branch from 8487f84 to b667353 Compare January 10, 2024 20:19
@wyattjoh wyattjoh merged commit 55917c0 into canary Jan 10, 2024
68 checks passed
@wyattjoh wyattjoh deleted the feat/transition-checks-to-retries branch January 10, 2024 21:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants