Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache reason for using fetch with noStore #60630

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 14, 2024

When you're using noStore() with fetch it's currently saying "auto cache" in cache missed reason, adding "noStore call" here to show it's caused by using with unstable_noStore

 GET /no-store 200 in 4069ms
  │ GET https://next-data-api-endpoint.vercel.app/api/random?another-no-cache 200 in 257ms (cache: SKIP)
  │  │  Cache missed reason: (noStore call)

Closes NEXT-2097

@ijjk
Copy link
Member

ijjk commented Jan 14, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js log-no-store-reason Change
buildDuration 12.7s 12.9s ⚠️ +111ms
buildDurationCached 7.1s 6.1s N/A
nodeModulesSize 200 MB 200 MB N/A
nextStartRea..uration (ms) 431ms 431ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js log-no-store-reason Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.4 kB 53.3 kB N/A
433-HASH.js gzip 28.9 kB 28.7 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.2 kB 45.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js log-no-store-reason Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js log-no-store-reason Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.28 kB 4.28 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js log-no-store-reason Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js log-no-store-reason Change
index.html gzip 527 B 527 B
link.html gzip 540 B 540 B
withRouter.html gzip 523 B 522 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js log-no-store-reason Change
edge-ssr.js gzip 93.8 kB 93.8 kB N/A
page.js gzip 148 kB 148 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js log-no-store-reason Change
middleware-b..fest.js gzip 622 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.5 kB 37.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary vercel/next.js log-no-store-reason Change
app-page-exp...dev.js gzip 169 kB 169 kB N/A
app-page-exp..prod.js gzip 95.3 kB 95.2 kB N/A
app-page-tur..prod.js gzip 96 kB 95.9 kB N/A
app-page-tur..prod.js gzip 90.5 kB 90.5 kB N/A
app-page.run...dev.js gzip 142 kB 142 kB N/A
app-page.run..prod.js gzip 89.9 kB 89.8 kB N/A
app-route-ex...dev.js gzip 24.1 kB 24.1 kB N/A
app-route-ex..prod.js gzip 16.7 kB 16.8 kB N/A
app-route-tu..prod.js gzip 16.7 kB 16.8 kB N/A
app-route-tu..prod.js gzip 16.3 kB 16.3 kB N/A
app-route.ru...dev.js gzip 23.5 kB 23.5 kB N/A
app-route.ru..prod.js gzip 16.3 kB 16.3 kB N/A
pages-api-tu..prod.js gzip 9.38 kB 9.38 kB
pages-api.ru...dev.js gzip 9.65 kB 9.65 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.6 kB 49.6 kB
Overall change 144 kB 144 kB
Diff details
Diff for page.js

Diff too large to display

Diff for 3f784ff6-HASH.js

Diff too large to display

Diff for 433-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: 6ebfea5

@ijjk
Copy link
Member

ijjk commented Jan 14, 2024

Tests Passed

@huozhi huozhi marked this pull request as ready for review January 14, 2024 15:14
@huozhi huozhi requested a review from ijjk January 14, 2024 20:14
@huozhi huozhi merged commit bfd10b3 into canary Jan 14, 2024
67 checks passed
@huozhi huozhi deleted the log-no-store-reason branch January 14, 2024 21:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants