Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip postcss config location resolving in node_modules #60697

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Skip postcss config location resolving in node_modules #60697

merged 5 commits into from
Jan 17, 2024

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Jan 16, 2024 •
edited by padmaia
Loading

What?

Skip postcss config resolving in node_modules for Turbopack. This matches current Next.js on webpack closer as that only resolves the postcss config from the project root. The additional feature Turbopack has is that it can find a postcss config relative to the css being compiled. This is useful for e.g. reducing the amount of overhead certain postcss plugins that only have to run against a single file take (i.e. Tailwindcss).

Depends on github.com/vercel/turborepo/pull/7012 landing first.

Closes NEXT-2109

@timneutkens timneutkens requested review from ijjk, shuding, huozhi and a team as code owners January 16, 2024 09:44
@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Next.js team PRs by the Next.js team. type: next labels Jan 16, 2024
@timneutkens Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@timneutkens timneutkens marked this pull request as draft January 16, 2024 09:45
sokra
sokra reviewed Jan 17, 2024
View reviewed changes
packages/next-swc/crates/next-core/src/next_server/context.rs
enable_typescript_transform: Some(tsconfig),
enable_mdx_rs,
decorators: Some(decorators_options),
rules: vec![
(
foreign_code_context_condition,
module_options_context.clone().cell(),
foreign_code_module_options_context.cell(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a bug before too

sokra
sokra reviewed Jan 17, 2024
View reviewed changes
packages/next-swc/crates/next-core/src/next_server/context.rs
enable_typescript_transform: Some(tsconfig),
enable_mdx_rs,
decorators: Some(decorators_options),
rules: vec![
(
foreign_code_context_condition,
module_options_context.clone().cell(),
foreign_code_module_options_context.cell(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a bug before too

@ijjk
Copy link
Member

ijjk commented Jan 17, 2024 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 01-16-Skip_postcss_config_location_resolving_in_node_modules Change
buildDuration 12.8s 12.9s N/A
buildDurationCached 7.2s 6.1s N/A
nodeModulesSize 200 MB 200 MB ✓
nextStartRea..uration (ms) 421ms 436ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-16-Skip_postcss_config_location_resolving_in_node_modules Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB ✓
433-HASH.js gzip 29 kB 29 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 239 B 242 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.6 kB 98.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-16-Skip_postcss_config_location_resolving_in_node_modules Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 01-16-Skip_postcss_config_location_resolving_in_node_modules Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.28 kB 4.28 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB ✓
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.4 kB 3.4 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 01-16-Skip_postcss_config_location_resolving_in_node_modules Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-16-Skip_postcss_config_location_resolving_in_node_modules Change
index.html gzip 528 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-16-Skip_postcss_config_location_resolving_in_node_modules Change
edge-ssr.js gzip 93.9 kB 93.9 kB N/A
page.js gzip 148 kB 148 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js 01-16-Skip_postcss_config_location_resolving_in_node_modules Change
middleware-b..fest.js gzip 625 B 625 B ✓
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 37.5 kB 37.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 2.7 kB 2.7 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js 01-16-Skip_postcss_config_location_resolving_in_node_modules Change
app-page-exp...dev.js gzip 169 kB 169 kB ✓
app-page-exp..prod.js gzip 95.6 kB 95.6 kB ✓
app-page-tur..prod.js gzip 96.3 kB 96.3 kB ✓
app-page-tur..prod.js gzip 90.8 kB 90.8 kB ✓
app-page.run...dev.js gzip 142 kB 142 kB ✓
app-page.run..prod.js gzip 90.2 kB 90.2 kB ✓
app-route-ex...dev.js gzip 24.2 kB 24.2 kB ✓
app-route-ex..prod.js gzip 16.8 kB 16.8 kB ✓
app-route-tu..prod.js gzip 16.8 kB 16.8 kB ✓
app-route-tu..prod.js gzip 16.4 kB 16.4 kB ✓
app-route.ru...dev.js gzip 23.6 kB 23.6 kB ✓
app-route.ru..prod.js gzip 16.4 kB 16.4 kB ✓
pages-api-tu..prod.js gzip 9.39 kB 9.39 kB ✓
pages-api.ru...dev.js gzip 9.67 kB 9.67 kB ✓
pages-api.ru..prod.js gzip 9.39 kB 9.39 kB ✓
pages-turbo...prod.js gzip 22 kB 22 kB ✓
pages.runtim...dev.js gzip 22.6 kB 22.6 kB ✓
pages.runtim..prod.js gzip 22 kB 22 kB ✓
server.runti..prod.js gzip 49.7 kB 49.7 kB ✓
Overall change 943 kB 943 kB ✓
Commit: ae660b9

@ijjk
Copy link
Member

ijjk commented Jan 17, 2024 •
edited
Loading

Tests Passed

@sokra sokra marked this pull request as ready for review January 17, 2024 12:21
@sokra sokra enabled auto-merge (squash) January 17, 2024 13:25
@sokra sokra merged commit 4548fed into canary Jan 17, 2024
69 checks passed
@sokra sokra deleted the 01-16-Skip_postcss_config_location_resolving_in_node_modules branch January 17, 2024 13:54
@vordgi vordgi mentioned this pull request Jan 21, 2024
Open
@github-actions github-actions bot added the locked label Feb 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timneutkens @ijjk @sokra