Fix first render of with-react-helmet example #6235
Merged
+44
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3534.
Helmet was being rendered in
<Head>in_document.js. BecausegetInitialPropsand thereforHelmet.renderStatic()gets called before the document is rendered withrenderToStaticMarkup, the meta-tags inside of document would not get flushed until the next request.I moved the default helmet-metadata into
_app.jsinstead which gets rendered before theHelmet.renderStatic()-call. This fixed the problem.Also did some minor cleaning up/simplification.