Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next/image): add missing svg test and refactor missing types #65345

Merged
merged 15 commits into from
May 6, 2024

Conversation

styfle
Copy link
Member

@styfle styfle commented May 4, 2024

The tests added in #46219 were never correctly testing the headers because detectContentType() is called first and only when we can't detect the type from the response body do we fallback to the Content-Type header.

I also refactored some of the tests because the ctx: any type was causing some tests to not run when testing different configuration options.

Closes NEXT-3321

@styfle styfle requested review from manovotny and delbaoliveira and removed request for a team May 4, 2024 00:11
@styfle styfle enabled auto-merge (squash) May 4, 2024 00:12
@ijjk
Copy link
Member

ijjk commented May 4, 2024

Failing test suites

Commit: 9f9805b

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/navigation/navigation.test.ts (PPR)

  • app dir - navigation > navigating to dynamic params & changing the casing > should load the page correctly
Expand output

● app dir - navigation › navigating to dynamic params & changing the casing › should load the page correctly

expect(received).toContain(expected) // indexOf

Expected substring: "[paramB] page"
Received string:    "/paramA/paramB
/paramA/noParam"

  884 |
  885 |       await retry(async () => {
> 886 |         expect(await browser.elementByCss('body').text()).toContain(
      |                                                           ^
  887 |           '[paramB] page'
  888 |         )
  889 |       })

  at toContain (e2e/app-dir/navigation/navigation.test.ts:886:59)
  at retry (lib/next-test-utils.ts:774:14)
  at Object.<anonymous> (e2e/app-dir/navigation/navigation.test.ts:885:7)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented May 4, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js styfle/fix-svg-img-test Change
buildDuration 27.8s 26.7s N/A
buildDurationCached 15.2s 13.7s N/A
nodeModulesSize 360 MB 360 MB ⚠️ +1.37 kB
nextStartRea..uration (ms) 745ms 752ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js styfle/fix-svg-img-test Change
1103-HASH.js gzip 31.9 kB 31.9 kB N/A
1a9f679d-HASH.js gzip 53.5 kB 53.5 kB N/A
335-HASH.js gzip 5.05 kB 5.05 kB
7953.HASH.js gzip 169 B 169 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 231 B 229 B N/A
main-HASH.js gzip 31.6 kB 31.6 kB N/A
webpack-HASH.js gzip 1.65 kB 1.65 kB N/A
Overall change 50.4 kB 50.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js styfle/fix-svg-img-test Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js styfle/fix-svg-img-test Change
_app-HASH.js gzip 192 B 193 B N/A
_error-HASH.js gzip 192 B 193 B N/A
amp-HASH.js gzip 507 B 511 B N/A
css-HASH.js gzip 341 B 343 B N/A
dynamic-HASH.js gzip 2.52 kB 2.52 kB
edge-ssr-HASH.js gzip 266 B 265 B N/A
head-HASH.js gzip 362 B 365 B N/A
hooks-HASH.js gzip 392 B 392 B
image-HASH.js gzip 4.27 kB 4.27 kB
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.69 kB 2.7 kB N/A
routerDirect..HASH.js gzip 329 B 328 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 324 B 324 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 8.27 kB 8.27 kB
Client Build Manifests
vercel/next.js canary vercel/next.js styfle/fix-svg-img-test Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js styfle/fix-svg-img-test Change
index.html gzip 528 B 526 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js styfle/fix-svg-img-test Change
edge-ssr.js gzip 94.9 kB 94.9 kB N/A
page.js gzip 182 kB 182 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js styfle/fix-svg-img-test Change
middleware-b..fest.js gzip 620 B 624 B N/A
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 25.7 kB 25.7 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 995 B 995 B
Next Runtimes
vercel/next.js canary vercel/next.js styfle/fix-svg-img-test Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.8 kB 98.8 kB
app-page-tur..prod.js gzip 100 kB 100 kB
app-page-tur..prod.js gzip 94.6 kB 94.6 kB
app-page.run...dev.js gzip 157 kB 157 kB
app-page.run..prod.js gzip 93.3 kB 93.3 kB
app-route-ex...dev.js gzip 21.5 kB 21.5 kB
app-route-ex..prod.js gzip 15.3 kB 15.3 kB
app-route-tu..prod.js gzip 15.3 kB 15.3 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route.ru...dev.js gzip 21.4 kB 21.4 kB
app-route.ru..prod.js gzip 15 kB 15 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.1 kB 22.1 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 51.8 kB 51.8 kB
Overall change 964 kB 964 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js styfle/fix-svg-img-test Change
0.pack gzip 1.62 MB 1.62 MB ⚠️ +385 B
index.pack gzip 114 kB 114 kB N/A
Overall change 1.62 MB 1.62 MB ⚠️ +385 B
Diff details
Diff for edge-ssr.js

Diff too large to display

Commit: 9f9805b

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like tests are failing

@styfle styfle changed the title fix(next/image): add missing svg test refactor missing types fix(next/image): add missing svg test and refactor missing types May 6, 2024
@styfle styfle merged commit 3dc2e67 into canary May 6, 2024
74 of 80 checks passed
@styfle styfle deleted the styfle/fix-svg-img-test branch May 6, 2024 22:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants