Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t prefetch outside of production #6578

Merged
merged 3 commits into from
Mar 8, 2019

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Mar 8, 2019

Fixes #1827

This doesn't affect integration tests as they'd use next build which forces production mode. Development forces development.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js fix/dont-prefetch-test Change
Build Duration 16s 16s ⚠️ +0.26%
Client _app Size 2.67 kB 2.67 kB
Client _app gzip Size 1.12 kB 1.12 kB
Client _error Size 6.56 kB 6.56 kB
Client _error gzip Size 2.77 kB 2.77 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client main Size 20.2 kB 20.2 kB
Client main gzip Size 6.77 kB 6.77 kB
Client commons Size 190 kB 190 kB
Client commons gzip Size 61.2 kB 61.2 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.2 kB 1.2 kB
Build Dir Size 385 kB 385 kB
Average Memory Usage 149 MB 148 MB -0.51%
Max Memory Usage 208 MB 208 MB 0%
Average CPU Usage 95.91% 95.98% ⚠️ +0.07%
Max CPU Usage 110% 111.11% ⚠️ +1.01%
node_modules Size 42.8 MB 42.9 MB ⚠️ +0.19%

@ijjk
Copy link
Member

ijjk commented Mar 8, 2019

Looks like the unit test needs to be updated but besides that lgtm

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js fix/dont-prefetch-test Change
Build Duration 16s 15.7s -1.68%
Client _app Size 2.67 kB 2.67 kB
Client _app gzip Size 1.12 kB 1.12 kB
Client _error Size 6.56 kB 6.56 kB
Client _error gzip Size 2.77 kB 2.77 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client main Size 20.2 kB 20.2 kB
Client main gzip Size 6.77 kB 6.77 kB
Client commons Size 190 kB 190 kB
Client commons gzip Size 61.2 kB 61.2 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.2 kB 1.2 kB
Build Dir Size 385 kB 385 kB
Average Memory Usage 148 MB 147 MB -0.67%
Max Memory Usage 208 MB 208 MB -0.09%
Average CPU Usage 97.88% 93.68% -4.29%
Max CPU Usage 111.11% 111.11%
node_modules Size 42.8 MB 42.8 MB 0%

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js fix/dont-prefetch-test Change
Build Duration 17.1s 19.2s ⚠️ +12.68%
Client _app Size 2.67 kB 2.67 kB
Client _app gzip Size 1.12 kB 1.12 kB
Client _error Size 6.56 kB 6.56 kB
Client _error gzip Size 2.77 kB 2.77 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client main Size 20.2 kB 20.2 kB
Client main gzip Size 6.77 kB 6.77 kB
Client commons Size 190 kB 190 kB
Client commons gzip Size 61.2 kB 61.2 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.2 kB 1.2 kB
Build Dir Size 385 kB 385 kB
Average Memory Usage 147 MB 145 MB -1.48%
Max Memory Usage 208 MB 201 MB -3.28%
Average CPU Usage 95.91% 92.94% -3.1%
Max CPU Usage 111.11% 122.22% ⚠️ +10%
node_modules Size 42.8 MB 42.8 MB 0%

@timneutkens timneutkens merged commit 3c04b0f into vercel:canary Mar 8, 2019
@timneutkens timneutkens deleted the fix/dont-prefetch-test branch March 8, 2019 19:09
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest example fails with next/link
3 participants