Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add chromedriver retrying from previous webdriver setup #6846

Merged
merged 3 commits into from
Apr 1, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 1, 2019

Azure seems to need the retrying setup we previously had for webdriver to pass more consistently so I re-added it and added falling back to the new setup for BrowserStack tests.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/chromedriver Change
Build Duration 12.7s 12.4s -326ms
Client _app Size 3.03 kB 3.03 kB
Client _app gzip Size 1.29 kB 1.29 kB
Client _error Size 8.85 kB 8.85 kB
Client _error gzip Size 3.31 kB 3.31 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 22.1 kB 22.1 kB
Client main gzip Size 7.24 kB 7.24 kB
Client commons Size 182 kB 182 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.3 kB 1.3 kB
Total Bundle (main, webpack, commons) Size 208 kB 208 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB
Build Dir Size 346 kB 346 kB
node_modules Size 42.7 MB 42.7 MB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/chromedriver Change
Build Duration 15.9s 16s ⚠️ +67ms
Client _app Size 3.03 kB 3.03 kB
Client _app gzip Size 1.29 kB 1.29 kB
Client _error Size 8.85 kB 8.85 kB
Client _error gzip Size 3.31 kB 3.31 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 22.1 kB 22.1 kB
Client main gzip Size 7.24 kB 7.24 kB
Client commons Size 182 kB 182 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 220 kB 220 kB
Serverless pages/link gzip Size 58 kB 58 kB
Serverless pages/index Size 215 kB 215 kB
Serverless pages/index gzip Size 56.8 kB 56.8 kB -1 B
Serverless pages/_error Size 217 kB 217 kB
Serverless pages/_error gzip Size 56.8 kB 56.8 kB
Serverless pages/routerDirect Size 216 kB 216 kB
Serverless pages/routerDirect gzip Size 56.8 kB 56.8 kB -1 B
Serverless pages/withRouter Size 216 kB 216 kB
Serverless pages/withRouter gzip Size 56.8 kB 56.8 kB
Total Bundle (main, webpack, commons) Size 208 kB 208 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB
Build Dir Size 1.31 MB 1.31 MB
node_modules Size 42.7 MB 42.7 MB

@timneutkens timneutkens merged commit 14eef58 into vercel:canary Apr 1, 2019
@ijjk ijjk deleted the fix/chromedriver branch April 1, 2019 14:17
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants