Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid "ad" anywhere in the biuldId #6854

Merged
merged 6 commits into from
Apr 2, 2019
Merged

Avoid "ad" anywhere in the biuldId #6854

merged 6 commits into from
Apr 2, 2019

Commits on Apr 1, 2019

  1. Added a check for ad_ in the buildId

    @lfades
    lfades committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    e42b517 View commit details
    Browse the repository at this point in the history

  2. ad_ > ad 

    Co-Authored-By: lfades <[email protected]>
    @Timer
    Timer and lfades authored Apr 1, 2019
    Configuration menu
    Copy the full SHA
    1aceb64 View commit details
    Browse the repository at this point in the history

  3. Update the ad comment 

    Co-Authored-By: lfades <[email protected]>
    @Timer
    Timer and lfades authored Apr 1, 2019
    Configuration menu
    Copy the full SHA
    a3d7fab View commit details
    Browse the repository at this point in the history

  4. Avoid all buildId's that contain "ad" 

    Looking through the uBlock Origin filter list, it uses regex wildcards to avoid various things with "ad" anywhere in the string. It's a safe bet to just avoid "ad" all together (as opposed to just at the start).
    @shahzeb1
    shahzeb1 authored Apr 1, 2019
    Configuration menu
    Copy the full SHA
    0ab8d49 View commit details
    Browse the repository at this point in the history

  5. Use regex (case incensitive) to check for "ad" 

    The following cases will set this regex to true:

```
/ad/i.test("somead")
/ad/i.test("someADlksdjf")
/ad/i.test("adlksdjf")
/ad/i.test("ADlksdjf")
```
    @shahzeb1
    shahzeb1 authored Apr 1, 2019
    Configuration menu
    Copy the full SHA
    1edc0d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. Merge branch 'canary' into buildid-no-ad_

    @Timer
    Timer authored Apr 2, 2019
    Configuration menu
    Copy the full SHA
    f70c69e View commit details
    Browse the repository at this point in the history