Tweak expireTime document a bit more #71199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Next.js team
sebmarkbage
reviewed
Oct 12, 2024
| Now instead of the default of 1 year `stale-while-revalidate` period being provided in the `Cache-Control` header, the custom period will be included. | ||
| Now when sending the `Cache-Control` header the expire time will be calculated depending on the specific revalidate period. | ||
|
|
||
| For example, if you have a revalidate of 30 seconds on a path and the expire time is 31536000 seconds the generated `Cache-Control` header will be `s-maxage=30, stale-while-revalidate=31535970` so that it can stay stale for 30 seconds less than the configured expire time. |
There was a problem hiding this comment.
Having two numbers so far apart doesn't really show the difference since who cares?
Maybe an example of 15 minutes and expire in 60 minutes shows it better?
sebmarkbage
approved these changes
Oct 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #71159 this tweaks the docs to explain the new behavior a bit more and re-word some parts.