[next@14] Update eslint-plugin-react-hooks to stable v5

[lorand-horvath]

eslint-plugin-react-hooks should be bumped to stable v5 for next@14 as well.
Justification here: #71218 (comment)

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: cf2bc75

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[eps1lon]

Using [email protected] is a breaking change. If anything, we should backport a downgrade. Existing apps just didn't see the breaking change during upgrade when they were using lockfiles.

[lorand-horvath]

Using [email protected] is a breaking change.

@eps1lon Why so? At the moment next@14 has a dependency on ^4.5.0 || 5.0.0-canary-7118f5dd7-20230705. I actually wonder why the 5.0.0-canary (from July 2023) was added in the first place? I have a justification for why v5 is a better solution, if you don't mind reading it, here: #71218 (comment)

Also eslint-plugin-react-hooks@5 supports eslint versions ^3 to ^9 as per https://github.com/facebook/react/blob/main/packages/eslint-plugin-react-hooks/package.json

Anyway, if v5 is not acceptable, I can modify the PR to downgrade it to ^4.6.2.

[eps1lon]

Using [email protected] is a breaking change.

Generally, because it's released in a SemVer major. Here specifically, it's the introduction of a new violation.

It's not a critical fix. Technically breaking again if you already relied on the new behavior considering for how long this has been out there. I don't see a path to safely backport nor the urgency to do this. You could always use resolutions or overrides to fix it.