Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing await of params when metadata is used with an image file #71871

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Fix missing await of params when metadata is used with an image file #71871

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
204f2dd
Fix missing `await` of `params` when metadata is used
gadcam Oct 25, 2024
f9535de
Annotate generated function as `async`
gadcam Oct 28, 2024
bb268be
Await callsite of generated metadata module
gadcam Oct 28, 2024
51a2d8e
Revert unnecessary `await`
gadcam Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/src/build/webpack/loaders/next-metadata-image-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ async function nextMetadataImageLoader(
const imageData = ${JSON.stringify(imageData)}
const imageUrl = fillMetadataSegment(${JSON.stringify(
pathnamePrefix
)}, props.params, ${JSON.stringify(pageSegment)})
)}, await props.params, ${JSON.stringify(pageSegment)})
eps1lon marked this conversation as resolved.
Show resolved Hide resolved

return [{
...imageData,
Expand Down
Loading