Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match public files priority in dev #8641

Merged
merged 15 commits into from
Sep 16, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 5, 2019

This makes sure to check for a public file before checking for a dynamic route in development mode since that is the behavior in production mode.

Continuation of: #7762
Closes: #8008
x-ref: #8063

@ijjk
Copy link
Member Author

ijjk commented Sep 5, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 20.8s 20.7s -40ms
nodeModulesSize 42 MB 42 MB ⚠️ +746 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB
main-HASH.js gzip 6.64 kB 6.64 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
51109c64ddb93a02e4c12f08c9586f9d74f694ad.e2c00d0314f283e7a4a0.js 42.9 kB N/A N/A
51109c64ddb93a02e4c12f08c9586f9d74f694ad.e2c00d0314f283e7a4a0.js gzip 15.4 kB N/A N/A
aa833bf6e00ffd8fa96d73e85dc49ef233ceac69.1f064d5355d2b8407376.js 21.9 kB N/A N/A
aa833bf6e00ffd8fa96d73e85dc49ef233ceac69.1f064d5355d2b8407376.js gzip 7.81 kB N/A N/A
framework.5b4f940f1eadbaff70d3.js 125 kB 125 kB
framework.5b4f940f1eadbaff70d3.js gzip 39.4 kB 39.4 kB
21b1dc30d018ea44f69d7caad2a86d64b7d84b7d.1f064d5355d2b8407376.js N/A 21.9 kB N/A
21b1dc30d018ea44f69d7caad2a86d64b7d84b7d.1f064d5355d2b8407376.js gzip N/A 7.81 kB N/A
8e37114b7f3d11f7371d8fc2419a96123114fe98.e2c00d0314f283e7a4a0.js N/A 42.9 kB N/A
8e37114b7f3d11f7371d8fc2419a96123114fe98.e2c00d0314f283e7a4a0.js gzip N/A 15.4 kB N/A
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.6 kB 16.6 kB
main-HASH.module.js gzip 6.38 kB 6.38 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH.module.js gzip 746 B 746 B
51109c64ddb93a02e4c12f08c9586f9d74f694ad.36c6b20a7d953b3f28f0.module.js 45.5 kB N/A N/A
51109c64ddb93a02e4c12f08c9586f9d74f694ad.36c6b20a7d953b3f28f0.module.js gzip 16.5 kB N/A N/A
framework.5b4f940f1eadbaff70d3.module.js 125 kB 125 kB
framework.5b4f940f1eadbaff70d3.module.js gzip 39.4 kB 39.4 kB
8e37114b7f3d11f7371d8fc2419a96123114fe98.36c6b20a7d953b3f28f0.module.js N/A 45.5 kB N/A
8e37114b7f3d11f7371d8fc2419a96123114fe98.36c6b20a7d953b3f28f0.module.js gzip N/A 16.5 kB N/A
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.83 kB 1.83 kB
_app.js gzip 883 B 883 B
_error.js 12.1 kB 12.1 kB
_error.js gzip 4.74 kB 4.74 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.81 kB 4.81 kB
index.js 343 B 343 B
index.js gzip 237 B 237 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.49 kB 3.49 kB
routerDirect.js 433 B 433 B
routerDirect.js gzip 296 B 296 B
withRouter.js 444 B 444 B
withRouter.js gzip 294 B 294 B
Overall change 36 kB 36 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.73 kB 1.73 kB
_app.module.js gzip 841 B 841 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.6 kB 8.6 kB
hooks.module.js 1.55 kB 1.55 kB
hooks.module.js gzip 804 B 804 B
index.module.js 319 B 319 B
index.module.js gzip 238 B 238 B
link.module.js 8.52 kB 8.52 kB
link.module.js gzip 3.67 kB 3.67 kB
routerDirect.module.js 419 B 419 B
routerDirect.module.js gzip 294 B 294 B
withRouter.module.js 429 B 429 B
withRouter.module.js gzip 293 B 293 B
Overall change 36.2 kB 36.2 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManifest.module.js gzip 61 B 61 B
Overall change 162 B 162 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
index.html 3.75 kB 3.75 kB
index.html gzip 959 B 957 B -2 B
link.html 3.79 kB 3.79 kB
link.html gzip 968 B 965 B -3 B
withRouter.html 3.8 kB 3.8 kB
withRouter.html gzip 955 B 952 B -3 B
Overall change 11.3 kB 11.3 kB

Diffs

Diff for index.html
@@ -6,9 +6,9 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/index.module.js"
+        <link rel="preload" href="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
@@ -16,9 +16,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/93a13ac5f9cf3dbfdbe6c9ed8b3790f40c73fe54.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/08f1f0faa564c068c1ea87355944d9a411832e94.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/KboR0hOHUbv7FG7x6MfkF/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/JGcWHLZE9QzyujdvrT0Ut/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,18 +26,18 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"KboR0hOHUbv7FG7x6MfkF"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"JGcWHLZE9QzyujdvrT0Ut"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -51,15 +51,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/e8eb4dcc6da5fd863493c4f235a63c1131c663dd.155621535702fe040780.js"
+        <script src="/_next/static/chunks/abbd853d5fe328eb239b8ec9655b016487f44901.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/93a13ac5f9cf3dbfdbe6c9ed8b3790f40c73fe54.474e0ebc58bce106266f.js"
+        <script src="/_next/static/chunks/08f1f0faa564c068c1ea87355944d9a411832e94.474e0ebc58bce106266f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/93a13ac5f9cf3dbfdbe6c9ed8b3790f40c73fe54.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/08f1f0faa564c068c1ea87355944d9a411832e94.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/KboR0hOHUbv7FG7x6MfkF/_buildManifest.js"
+        <script src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/KboR0hOHUbv7FG7x6MfkF/_buildManifest.module.js"
+        <script src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for link.html
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/link.module.js"
+        <link rel="preload" href="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/93a13ac5f9cf3dbfdbe6c9ed8b3790f40c73fe54.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/08f1f0faa564c068c1ea87355944d9a411832e94.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/KboR0hOHUbv7FG7x6MfkF/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/JGcWHLZE9QzyujdvrT0Ut/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"KboR0hOHUbv7FG7x6MfkF"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"JGcWHLZE9QzyujdvrT0Ut"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/e8eb4dcc6da5fd863493c4f235a63c1131c663dd.155621535702fe040780.js"
+        <script src="/_next/static/chunks/abbd853d5fe328eb239b8ec9655b016487f44901.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/93a13ac5f9cf3dbfdbe6c9ed8b3790f40c73fe54.474e0ebc58bce106266f.js"
+        <script src="/_next/static/chunks/08f1f0faa564c068c1ea87355944d9a411832e94.474e0ebc58bce106266f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/93a13ac5f9cf3dbfdbe6c9ed8b3790f40c73fe54.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/08f1f0faa564c068c1ea87355944d9a411832e94.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/KboR0hOHUbv7FG7x6MfkF/_buildManifest.js"
+        <script src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/KboR0hOHUbv7FG7x6MfkF/_buildManifest.module.js"
+        <script src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for withRouter.html
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/93a13ac5f9cf3dbfdbe6c9ed8b3790f40c73fe54.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/08f1f0faa564c068c1ea87355944d9a411832e94.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/KboR0hOHUbv7FG7x6MfkF/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/JGcWHLZE9QzyujdvrT0Ut/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"KboR0hOHUbv7FG7x6MfkF"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"JGcWHLZE9QzyujdvrT0Ut"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/KboR0hOHUbv7FG7x6MfkF/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/e8eb4dcc6da5fd863493c4f235a63c1131c663dd.155621535702fe040780.js"
+        <script src="/_next/static/chunks/abbd853d5fe328eb239b8ec9655b016487f44901.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/93a13ac5f9cf3dbfdbe6c9ed8b3790f40c73fe54.474e0ebc58bce106266f.js"
+        <script src="/_next/static/chunks/08f1f0faa564c068c1ea87355944d9a411832e94.474e0ebc58bce106266f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/93a13ac5f9cf3dbfdbe6c9ed8b3790f40c73fe54.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/08f1f0faa564c068c1ea87355944d9a411832e94.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/KboR0hOHUbv7FG7x6MfkF/_buildManifest.js"
+        <script src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/KboR0hOHUbv7FG7x6MfkF/_buildManifest.module.js"
+        <script src="/_next/static/JGcWHLZE9QzyujdvrT0Ut/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 21s 20.8s -146ms
nodeModulesSize 42 MB 42 MB ⚠️ +746 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB ⚠️ +1 B
main-HASH.js gzip 6.64 kB 6.64 kB ⚠️ +1 B
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
142749ad1489fc8b440b02d18404b805fa152b00.e2c00d0314f283e7a4a0.js 42.9 kB N/A N/A
142749ad1489fc8b440b02d18404b805fa152b00.e2c00d0314f283e7a4a0.js gzip 15.4 kB N/A N/A
723d4d8fbcf04c6eb3846d12e446ea59dd646a07.1f064d5355d2b8407376.js 21.9 kB N/A N/A
723d4d8fbcf04c6eb3846d12e446ea59dd646a07.1f064d5355d2b8407376.js gzip 7.81 kB N/A N/A
framework.5b4f940f1eadbaff70d3.js 125 kB 125 kB
framework.5b4f940f1eadbaff70d3.js gzip 39.4 kB 39.4 kB
0f74bd19e427e56ea13f17bde67dc134ac49defb.e2c00d0314f283e7a4a0.js N/A 42.9 kB N/A
0f74bd19e427e56ea13f17bde67dc134ac49defb.e2c00d0314f283e7a4a0.js gzip N/A 15.4 kB N/A
9d2f2be9ebd6bc097a30d6fa088f0fd053a56a97.1f064d5355d2b8407376.js N/A 21.9 kB N/A
9d2f2be9ebd6bc097a30d6fa088f0fd053a56a97.1f064d5355d2b8407376.js gzip N/A 7.81 kB N/A
Overall change 210 kB 210 kB ⚠️ +1 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.6 kB 16.6 kB ⚠️ +1 B
main-HASH.module.js gzip 6.38 kB 6.38 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH.module.js gzip 746 B 746 B
142749ad1489fc8b440b02d18404b805fa152b00.36c6b20a7d953b3f28f0.module.js 45.5 kB N/A N/A
142749ad1489fc8b440b02d18404b805fa152b00.36c6b20a7d953b3f28f0.module.js gzip 16.5 kB N/A N/A
framework.5b4f940f1eadbaff70d3.module.js 125 kB 125 kB
framework.5b4f940f1eadbaff70d3.module.js gzip 39.4 kB 39.4 kB
0f74bd19e427e56ea13f17bde67dc134ac49defb.36c6b20a7d953b3f28f0.module.js N/A 45.5 kB N/A
0f74bd19e427e56ea13f17bde67dc134ac49defb.36c6b20a7d953b3f28f0.module.js gzip N/A 16.5 kB N/A
Overall change 189 kB 189 kB ⚠️ +1 B
Client Pages Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.83 kB 1.83 kB
_app.js gzip 883 B 883 B
_error.js 12.1 kB 12.1 kB
_error.js gzip 4.74 kB 4.74 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.81 kB 4.81 kB
index.js 343 B 343 B
index.js gzip 237 B 237 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.49 kB 3.49 kB -1 B
routerDirect.js 434 B 433 B -1 B
routerDirect.js gzip 296 B 296 B
withRouter.js 444 B 444 B
withRouter.js gzip 294 B 294 B
Overall change 36 kB 36 kB -1 B
Client Pages Modern Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.73 kB 1.73 kB
_app.module.js gzip 840 B 841 B ⚠️ +1 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.6 kB 8.6 kB
hooks.module.js 1.55 kB 1.55 kB
hooks.module.js gzip 805 B 804 B -1 B
index.module.js 319 B 319 B
index.module.js gzip 238 B 238 B
link.module.js 8.52 kB 8.52 kB
link.module.js gzip 3.67 kB 3.67 kB
routerDirect.module.js 419 B 419 B
routerDirect.module.js gzip 294 B 294 B
withRouter.module.js 430 B 429 B -1 B
withRouter.module.js gzip 293 B 293 B
Overall change 36.2 kB 36.2 kB -1 B
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManifest.module.js gzip 61 B 61 B
Overall change 162 B 162 B
Serverless bundles
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_error.js 247 kB 247 kB
_error.js gzip 66.2 kB 66.2 kB ⚠️ +66 B
hooks.html 3.86 kB 3.86 kB
hooks.html gzip 990 B 983 B -7 B
index.js 248 kB 248 kB
index.js gzip 66.5 kB 66.4 kB -72 B
link.js 255 kB 255 kB
link.js gzip 68.5 kB 68.6 kB ⚠️ +62 B
routerDirect.js 249 kB 249 kB
routerDirect.js gzip 66.6 kB 66.4 kB -159 B
withRouter.js 249 kB 249 kB
withRouter.js gzip 66.6 kB 66.5 kB -60 B
Overall change 1.25 MB 1.25 MB

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Timer
Timer previously requested changes Sep 6, 2019
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we handling public files that did not conflict? Should we remove that code?

Why does a matching public file make it to the page loading step?

@ijjk ijjk added this to the 9.0.6 milestone Sep 6, 2019
@ijjk ijjk added the Type: Bug label Sep 6, 2019
@ijjk
Copy link
Member Author

ijjk commented Sep 6, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 23.1s 21.3s -1.8s
nodeModulesSize 42.4 MB 42.4 MB ⚠️ +363 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB
main-HASH.js gzip 6.64 kB 6.64 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
2b431d46c4d8..799a4e38e.js 43.1 kB N/A N/A
2b431d46c4d8..e38e.js gzip 15.4 kB N/A N/A
6c6289fe0d24..2b8407376.js 21.9 kB N/A N/A
6c6289fe0d24..7376.js gzip 7.81 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
47f44ceaa037..799a4e38e.js N/A 43.1 kB N/A
47f44ceaa037..e38e.js gzip N/A 15.4 kB N/A
ddde457716b3..2b8407376.js N/A 21.9 kB N/A
ddde457716b3..7376.js gzip N/A 7.81 kB N/A
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.6 kB 16.6 kB
main-HASH.module.js gzip 6.38 kB 6.38 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
2b431d46c4d8..f0.module.js 45.5 kB N/A N/A
2b431d46c4d8..dule.js gzip 16.5 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
47f44ceaa037..f0.module.js N/A 45.5 kB N/A
47f44ceaa037..dule.js gzip N/A 16.5 kB N/A
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.83 kB 1.83 kB
_app.js gzip 883 B 883 B
_error.js 12.1 kB 12.1 kB
_error.js gzip 4.74 kB 4.74 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.81 kB 4.81 kB
index.js 343 B 343 B
index.js gzip 237 B 237 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.49 kB 3.49 kB
routerDirect.js 433 B 433 B
routerDirect.js gzip 296 B 296 B
withRouter.js 444 B 444 B
withRouter.js gzip 294 B 294 B
Overall change 36 kB 36 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.73 kB 1.73 kB
_app.module.js gzip 841 B 841 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.6 kB 8.6 kB
hooks.module.js 1.55 kB 1.55 kB
hooks.module.js gzip 804 B 804 B
index.module.js 319 B 319 B
index.module.js gzip 238 B 238 B
link.module.js 8.52 kB 8.52 kB
link.module.js gzip 3.67 kB 3.67 kB
routerDirect.module.js 419 B 419 B
routerDirect..dule.js gzip 294 B 294 B
withRouter.module.js 429 B 429 B
withRouter.m..dule.js gzip 293 B 293 B
Overall change 36.2 kB 36.2 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
index.html 3.75 kB 3.75 kB
index.html gzip 960 B 957 B -3 B
link.html 3.79 kB 3.79 kB
link.html gzip 969 B 967 B -2 B
withRouter.html 3.8 kB 3.8 kB
withRouter.html gzip 956 B 953 B -3 B
Overall change 11.3 kB 11.3 kB

Diffs

Diff for index.html
@@ -6,9 +6,9 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/index.module.js"
+        <link rel="preload" href="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
@@ -16,9 +16,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/16a4b5088709793a6a23b00d5466326efa92fb16.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/c17a262f041c2840f33308b50663e35df408f658.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/NllH-7c-U4LMSxyAO4ZCi/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/bZBwOHemwNziBUWhh1L0i/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,18 +26,18 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"NllH-7c-U4LMSxyAO4ZCi"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"bZBwOHemwNziBUWhh1L0i"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -51,15 +51,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/343b58f11a94a6dc01e297582944758bc5ee360e.155621535702fe040780.js"
+        <script src="/_next/static/chunks/ecf1e9d72379df932599e538138a48f5911775d9.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/16a4b5088709793a6a23b00d5466326efa92fb16.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/c17a262f041c2840f33308b50663e35df408f658.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/16a4b5088709793a6a23b00d5466326efa92fb16.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/c17a262f041c2840f33308b50663e35df408f658.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/_buildManifest.js"
+        <script src="/_next/static/bZBwOHemwNziBUWhh1L0i/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/_buildManifest.module.js"
+        <script src="/_next/static/bZBwOHemwNziBUWhh1L0i/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for link.html
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/link.module.js"
+        <link rel="preload" href="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/16a4b5088709793a6a23b00d5466326efa92fb16.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/c17a262f041c2840f33308b50663e35df408f658.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/NllH-7c-U4LMSxyAO4ZCi/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/bZBwOHemwNziBUWhh1L0i/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"NllH-7c-U4LMSxyAO4ZCi"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"bZBwOHemwNziBUWhh1L0i"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/343b58f11a94a6dc01e297582944758bc5ee360e.155621535702fe040780.js"
+        <script src="/_next/static/chunks/ecf1e9d72379df932599e538138a48f5911775d9.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/16a4b5088709793a6a23b00d5466326efa92fb16.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/c17a262f041c2840f33308b50663e35df408f658.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/16a4b5088709793a6a23b00d5466326efa92fb16.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/c17a262f041c2840f33308b50663e35df408f658.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/_buildManifest.js"
+        <script src="/_next/static/bZBwOHemwNziBUWhh1L0i/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/_buildManifest.module.js"
+        <script src="/_next/static/bZBwOHemwNziBUWhh1L0i/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for withRouter.html
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/16a4b5088709793a6a23b00d5466326efa92fb16.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/c17a262f041c2840f33308b50663e35df408f658.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/NllH-7c-U4LMSxyAO4ZCi/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/bZBwOHemwNziBUWhh1L0i/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"NllH-7c-U4LMSxyAO4ZCi"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"bZBwOHemwNziBUWhh1L0i"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/bZBwOHemwNziBUWhh1L0i/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/343b58f11a94a6dc01e297582944758bc5ee360e.155621535702fe040780.js"
+        <script src="/_next/static/chunks/ecf1e9d72379df932599e538138a48f5911775d9.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/16a4b5088709793a6a23b00d5466326efa92fb16.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/c17a262f041c2840f33308b50663e35df408f658.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/16a4b5088709793a6a23b00d5466326efa92fb16.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/c17a262f041c2840f33308b50663e35df408f658.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/_buildManifest.js"
+        <script src="/_next/static/bZBwOHemwNziBUWhh1L0i/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/NllH-7c-U4LMSxyAO4ZCi/_buildManifest.module.js"
+        <script src="/_next/static/bZBwOHemwNziBUWhh1L0i/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 21.6s 21.9s ⚠️ +289ms
nodeModulesSize 42.4 MB 42.4 MB ⚠️ +363 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB ⚠️ +1 B
main-HASH.js gzip 6.64 kB 6.64 kB ⚠️ +1 B
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
e1aaf2ecd887..2b8407376.js 21.9 kB N/A N/A
e1aaf2ecd887..7376.js gzip 7.81 kB N/A N/A
fad11faca080..799a4e38e.js 43.1 kB N/A N/A
fad11faca080..e38e.js gzip 15.4 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
5843ecee1e23..2b8407376.js N/A 21.9 kB N/A
5843ecee1e23..7376.js gzip N/A 7.81 kB N/A
6f1f5becff87..799a4e38e.js N/A 43.1 kB N/A
6f1f5becff87..e38e.js gzip N/A 15.4 kB N/A
Overall change 210 kB 210 kB ⚠️ +1 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.6 kB 16.6 kB ⚠️ +1 B
main-HASH.module.js gzip 6.38 kB 6.38 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
fad11faca080..f0.module.js 45.5 kB N/A N/A
fad11faca080..dule.js gzip 16.5 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
6f1f5becff87..f0.module.js N/A 45.5 kB N/A
6f1f5becff87..dule.js gzip N/A 16.5 kB N/A
Overall change 189 kB 189 kB ⚠️ +1 B
Client Pages Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.83 kB 1.83 kB
_app.js gzip 883 B 883 B
_error.js 12.1 kB 12.1 kB
_error.js gzip 4.74 kB 4.74 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.81 kB 4.81 kB
index.js 343 B 343 B
index.js gzip 237 B 237 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.49 kB 3.49 kB -1 B
routerDirect.js 434 B 433 B -1 B
routerDirect.js gzip 296 B 296 B
withRouter.js 444 B 444 B
withRouter.js gzip 294 B 294 B
Overall change 36 kB 36 kB -1 B
Client Pages Modern Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.73 kB 1.73 kB
_app.module.js gzip 840 B 841 B ⚠️ +1 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.6 kB 8.6 kB
hooks.module.js 1.55 kB 1.55 kB
hooks.module.js gzip 805 B 804 B -1 B
index.module.js 319 B 319 B
index.module.js gzip 238 B 238 B
link.module.js 8.52 kB 8.52 kB
link.module.js gzip 3.67 kB 3.67 kB
routerDirect.module.js 419 B 419 B
routerDirect..dule.js gzip 294 B 294 B
withRouter.module.js 430 B 429 B -1 B
withRouter.m..dule.js gzip 293 B 293 B
Overall change 36.2 kB 36.2 kB -1 B
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Serverless bundles
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_error.js 247 kB 247 kB
_error.js gzip 66.2 kB 66.2 kB -32 B
hooks.html 3.86 kB 3.86 kB
hooks.html gzip 985 B 982 B -3 B
index.js 248 kB 248 kB
index.js gzip 66.5 kB 66.5 kB ⚠️ +58 B
link.js 255 kB 255 kB
link.js gzip 68.6 kB 68.6 kB ⚠️ +19 B
routerDirect.js 249 kB 249 kB
routerDirect.js gzip 66.5 kB 66.5 kB -27 B
withRouter.js 249 kB 249 kB
withRouter.js gzip 66.5 kB 66.5 kB -17 B
Overall change 1.25 MB 1.25 MB

@ijjk
Copy link
Member Author

ijjk commented Sep 6, 2019

Where are we handling public files that did not conflict? Should we remove that code?

It's now only in one place in development now, which is when a matching page isn't found it checks if there's a public file.

Why does a matching public file make it to the page loading step?

It only does in development mode since in production we load all the routes on start up but in development we don't to allow adding them as they go. So to have the correct priority of page > publicFile > dynamicPage we have to handle it here

Made the changes we discussed to prioritize public files and to error if there are conflicting files in development and during build

@ijjk
Copy link
Member Author

ijjk commented Sep 7, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 23.3s 22.3s -992ms
nodeModulesSize 42.4 MB 42.4 MB ⚠️ +3.23 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB
main-HASH.js gzip 6.64 kB 6.64 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
345ff50c8a16..799a4e38e.js 43.1 kB N/A N/A
345ff50c8a16..e38e.js gzip 15.4 kB N/A N/A
8aa1e213f02f..2b8407376.js 21.9 kB N/A N/A
8aa1e213f02f..7376.js gzip 7.81 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
688b9e30a0e0..799a4e38e.js N/A 43.1 kB N/A
688b9e30a0e0..e38e.js gzip N/A 15.4 kB N/A
bdbb4d536c80..2b8407376.js N/A 21.9 kB N/A
bdbb4d536c80..7376.js gzip N/A 7.81 kB N/A
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.6 kB 16.6 kB
main-HASH.module.js gzip 6.38 kB 6.38 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
345ff50c8a16..f0.module.js 45.5 kB N/A N/A
345ff50c8a16..dule.js gzip 16.5 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
688b9e30a0e0..f0.module.js N/A 45.5 kB N/A
688b9e30a0e0..dule.js gzip N/A 16.5 kB N/A
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.83 kB 1.83 kB
_app.js gzip 883 B 883 B
_error.js 12.1 kB 12.1 kB
_error.js gzip 4.74 kB 4.74 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.81 kB 4.81 kB
index.js 343 B 343 B
index.js gzip 237 B 237 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.49 kB 3.49 kB
routerDirect.js 433 B 433 B
routerDirect.js gzip 296 B 296 B
withRouter.js 444 B 444 B
withRouter.js gzip 294 B 294 B
Overall change 36 kB 36 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.73 kB 1.73 kB
_app.module.js gzip 841 B 841 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.6 kB 8.6 kB
hooks.module.js 1.55 kB 1.55 kB
hooks.module.js gzip 804 B 804 B
index.module.js 319 B 319 B
index.module.js gzip 238 B 238 B
link.module.js 8.52 kB 8.52 kB
link.module.js gzip 3.67 kB 3.67 kB
routerDirect.module.js 419 B 419 B
routerDirect..dule.js gzip 294 B 294 B
withRouter.module.js 429 B 429 B
withRouter.m..dule.js gzip 293 B 293 B
Overall change 36.2 kB 36.2 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
index.html 3.75 kB 3.75 kB
index.html gzip 959 B 959 B
link.html 3.79 kB 3.79 kB
link.html gzip 968 B 967 B -1 B
withRouter.html 3.8 kB 3.8 kB
withRouter.html gzip 954 B 954 B
Overall change 11.3 kB 11.3 kB

Diffs

Diff for index.html
@@ -6,9 +6,9 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/index.module.js"
+        <link rel="preload" href="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
@@ -16,9 +16,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/06dbaa8db3e97c25e787c3f4c2b41cb370873b60.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/199a7b9ce0f05e1bb7caed04d1a304eca07817f4.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/DTS5ENxcFSWusHKLw6OFw/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/FK5-qOQt_OLHgE3y1w31D/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,18 +26,18 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"DTS5ENxcFSWusHKLw6OFw"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"FK5-qOQt_OLHgE3y1w31D"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -51,15 +51,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/1a43175d5dc4087c87f3ad118de073a8b8e0b0a0.155621535702fe040780.js"
+        <script src="/_next/static/chunks/4423b3ae3f7fc7369708c8de82d722c549491e0b.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/06dbaa8db3e97c25e787c3f4c2b41cb370873b60.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/199a7b9ce0f05e1bb7caed04d1a304eca07817f4.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/06dbaa8db3e97c25e787c3f4c2b41cb370873b60.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/199a7b9ce0f05e1bb7caed04d1a304eca07817f4.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/DTS5ENxcFSWusHKLw6OFw/_buildManifest.js"
+        <script src="/_next/static/FK5-qOQt_OLHgE3y1w31D/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/DTS5ENxcFSWusHKLw6OFw/_buildManifest.module.js"
+        <script src="/_next/static/FK5-qOQt_OLHgE3y1w31D/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for link.html
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/link.module.js"
+        <link rel="preload" href="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/06dbaa8db3e97c25e787c3f4c2b41cb370873b60.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/199a7b9ce0f05e1bb7caed04d1a304eca07817f4.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/DTS5ENxcFSWusHKLw6OFw/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/FK5-qOQt_OLHgE3y1w31D/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"DTS5ENxcFSWusHKLw6OFw"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"FK5-qOQt_OLHgE3y1w31D"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/1a43175d5dc4087c87f3ad118de073a8b8e0b0a0.155621535702fe040780.js"
+        <script src="/_next/static/chunks/4423b3ae3f7fc7369708c8de82d722c549491e0b.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/06dbaa8db3e97c25e787c3f4c2b41cb370873b60.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/199a7b9ce0f05e1bb7caed04d1a304eca07817f4.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/06dbaa8db3e97c25e787c3f4c2b41cb370873b60.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/199a7b9ce0f05e1bb7caed04d1a304eca07817f4.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/DTS5ENxcFSWusHKLw6OFw/_buildManifest.js"
+        <script src="/_next/static/FK5-qOQt_OLHgE3y1w31D/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/DTS5ENxcFSWusHKLw6OFw/_buildManifest.module.js"
+        <script src="/_next/static/FK5-qOQt_OLHgE3y1w31D/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for withRouter.html
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/06dbaa8db3e97c25e787c3f4c2b41cb370873b60.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/199a7b9ce0f05e1bb7caed04d1a304eca07817f4.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/DTS5ENxcFSWusHKLw6OFw/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/FK5-qOQt_OLHgE3y1w31D/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"DTS5ENxcFSWusHKLw6OFw"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"FK5-qOQt_OLHgE3y1w31D"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/DTS5ENxcFSWusHKLw6OFw/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/FK5-qOQt_OLHgE3y1w31D/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/1a43175d5dc4087c87f3ad118de073a8b8e0b0a0.155621535702fe040780.js"
+        <script src="/_next/static/chunks/4423b3ae3f7fc7369708c8de82d722c549491e0b.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/06dbaa8db3e97c25e787c3f4c2b41cb370873b60.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/199a7b9ce0f05e1bb7caed04d1a304eca07817f4.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/06dbaa8db3e97c25e787c3f4c2b41cb370873b60.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/199a7b9ce0f05e1bb7caed04d1a304eca07817f4.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/DTS5ENxcFSWusHKLw6OFw/_buildManifest.js"
+        <script src="/_next/static/FK5-qOQt_OLHgE3y1w31D/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/DTS5ENxcFSWusHKLw6OFw/_buildManifest.module.js"
+        <script src="/_next/static/FK5-qOQt_OLHgE3y1w31D/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 23.4s 23s -415ms
nodeModulesSize 42.4 MB 42.4 MB ⚠️ +3.23 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB
main-HASH.js gzip 6.64 kB 6.64 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
69a1484a0920..799a4e38e.js 43.1 kB N/A N/A
69a1484a0920..e38e.js gzip 15.4 kB N/A N/A
d859dfcf7880..2b8407376.js 21.9 kB N/A N/A
d859dfcf7880..7376.js gzip 7.81 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
8e567d7e5bae..799a4e38e.js N/A 43.1 kB N/A
8e567d7e5bae..e38e.js gzip N/A 15.4 kB N/A
cc85d07adf6f..2b8407376.js N/A 21.9 kB N/A
cc85d07adf6f..7376.js gzip N/A 7.81 kB N/A
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.6 kB 16.6 kB
main-HASH.module.js gzip 6.38 kB 6.38 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
69a1484a0920..f0.module.js 45.5 kB N/A N/A
69a1484a0920..dule.js gzip 16.5 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
8e567d7e5bae..f0.module.js N/A 45.5 kB N/A
8e567d7e5bae..dule.js gzip N/A 16.5 kB N/A
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.83 kB 1.83 kB
_app.js gzip 883 B 883 B
_error.js 12.1 kB 12.1 kB
_error.js gzip 4.74 kB 4.74 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.81 kB 4.81 kB
index.js 343 B 343 B
index.js gzip 237 B 237 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.49 kB 3.49 kB
routerDirect.js 433 B 433 B
routerDirect.js gzip 296 B 296 B
withRouter.js 444 B 444 B
withRouter.js gzip 294 B 294 B
Overall change 36 kB 36 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.73 kB 1.73 kB
_app.module.js gzip 841 B 841 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.6 kB 8.6 kB
hooks.module.js 1.55 kB 1.55 kB
hooks.module.js gzip 804 B 804 B
index.module.js 319 B 319 B
index.module.js gzip 238 B 238 B
link.module.js 8.52 kB 8.52 kB
link.module.js gzip 3.67 kB 3.67 kB
routerDirect.module.js 419 B 419 B
routerDirect..dule.js gzip 294 B 294 B
withRouter.module.js 429 B 429 B
withRouter.m..dule.js gzip 293 B 293 B
Overall change 36.2 kB 36.2 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Serverless bundles
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_error.js 247 kB 247 kB
_error.js gzip 66.1 kB 66.2 kB ⚠️ +153 B
hooks.html 3.86 kB 3.86 kB
hooks.html gzip 986 B 982 B -4 B
index.js 248 kB 248 kB
index.js gzip 66.5 kB 66.5 kB -2 B
link.js 255 kB 255 kB
link.js gzip 68.6 kB 68.6 kB -11 B
routerDirect.js 249 kB 249 kB
routerDirect.js gzip 66.5 kB 66.5 kB -20 B
withRouter.js 249 kB 249 kB
withRouter.js gzip 66.6 kB 66.5 kB -60 B
Overall change 1.25 MB 1.25 MB

@ijjk
Copy link
Member Author

ijjk commented Sep 10, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 22s 21.2s -767ms
nodeModulesSize 42.4 MB 42.4 MB ⚠️ +3.23 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.3 kB 18.3 kB
main-HASH.js gzip 6.65 kB 6.65 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..799a4e38e.js 43.1 kB 43.1 kB
de003c3a9d30..e38e.js gzip 15.4 kB 15.4 kB
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.6 kB 16.6 kB
main-HASH.module.js gzip 6.4 kB 6.4 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..f0.module.js 45.5 kB 45.5 kB
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.83 kB 1.83 kB
_app.js gzip 883 B 883 B
_error.js 12.1 kB 12.1 kB
_error.js gzip 4.74 kB 4.74 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.81 kB 4.81 kB
index.js 343 B 343 B
index.js gzip 237 B 237 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.49 kB 3.49 kB
routerDirect.js 433 B 433 B
routerDirect.js gzip 296 B 296 B
withRouter.js 444 B 444 B
withRouter.js gzip 294 B 294 B
Overall change 36 kB 36 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.73 kB 1.73 kB
_app.module.js gzip 841 B 841 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.6 kB 8.6 kB
hooks.module.js 1.55 kB 1.55 kB
hooks.module.js gzip 804 B 804 B
index.module.js 319 B 319 B
index.module.js gzip 238 B 238 B
link.module.js 8.52 kB 8.52 kB
link.module.js gzip 3.67 kB 3.67 kB
routerDirect.module.js 419 B 419 B
routerDirect..dule.js gzip 294 B 294 B
withRouter.module.js 429 B 429 B
withRouter.m..dule.js gzip 293 B 293 B
Overall change 36.2 kB 36.2 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
index.html 3.62 kB 3.62 kB
index.html gzip 947 B 947 B
link.html 3.66 kB 3.66 kB
link.html gzip 956 B 956 B
withRouter.html 3.67 kB 3.67 kB
withRouter.html gzip 943 B 943 B
Overall change 10.9 kB 10.9 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 21.6s 21.6s ⚠️ +15ms
nodeModulesSize 42.4 MB 42.4 MB ⚠️ +3.23 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.3 kB 18.3 kB
main-HASH.js gzip 6.65 kB 6.65 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..799a4e38e.js 43.1 kB 43.1 kB
de003c3a9d30..e38e.js gzip 15.4 kB 15.4 kB
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.6 kB 16.6 kB
main-HASH.module.js gzip 6.4 kB 6.4 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..f0.module.js 45.5 kB 45.5 kB
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.83 kB 1.83 kB
_app.js gzip 883 B 883 B
_error.js 12.1 kB 12.1 kB
_error.js gzip 4.74 kB 4.74 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.81 kB 4.81 kB
index.js 343 B 343 B
index.js gzip 237 B 237 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.49 kB 3.49 kB
routerDirect.js 433 B 433 B
routerDirect.js gzip 296 B 296 B
withRouter.js 444 B 444 B
withRouter.js gzip 294 B 294 B
Overall change 36 kB 36 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.73 kB 1.73 kB
_app.module.js gzip 841 B 841 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.6 kB 8.6 kB
hooks.module.js 1.55 kB 1.55 kB
hooks.module.js gzip 804 B 804 B
index.module.js 319 B 319 B
index.module.js gzip 238 B 238 B
link.module.js 8.52 kB 8.52 kB
link.module.js gzip 3.67 kB 3.67 kB
routerDirect.module.js 419 B 419 B
routerDirect..dule.js gzip 294 B 294 B
withRouter.module.js 429 B 429 B
withRouter.m..dule.js gzip 293 B 293 B
Overall change 36.2 kB 36.2 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Serverless bundles
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_error.js 247 kB 247 kB
_error.js gzip 66.1 kB 66.1 kB
hooks.html 3.73 kB 3.73 kB
hooks.html gzip 973 B 973 B
index.js 248 kB 248 kB
index.js gzip 66.5 kB 66.5 kB
link.js 255 kB 255 kB
link.js gzip 68.5 kB 68.5 kB
routerDirect.js 249 kB 249 kB
routerDirect.js gzip 66.5 kB 66.5 kB
withRouter.js 248 kB 248 kB
withRouter.js gzip 66.6 kB 66.6 kB
Overall change 1.25 MB 1.25 MB

@Timer Timer modified the milestones: 9.0.6, 9.0.7 Sep 11, 2019
@ijjk
Copy link
Member Author

ijjk commented Sep 16, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 16.4s 16.3s -124ms
nodeModulesSize 41.9 MB 42 MB ⚠️ +4.66 kB
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB ⚠️ +46 B
main-HASH.js gzip 6.65 kB 6.66 kB ⚠️ +11 B
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..3fa59b1f5.js 43.1 kB N/A N/A
de003c3a9d30..b1f5.js gzip 15.5 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
de003c3a9d30..1c5d17695.js N/A 43.1 kB N/A
de003c3a9d30..7695.js gzip N/A 15.4 kB N/A
Overall change 210 kB 210 kB ⚠️ +46 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.5 kB 16.6 kB ⚠️ +50 B
main-HASH.module.js gzip 6.39 kB 6.4 kB ⚠️ +11 B
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..4b.module.js 45.5 kB N/A N/A
de003c3a9d30..dule.js gzip 16.5 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
de003c3a9d30..5f.module.js N/A 45.5 kB N/A
de003c3a9d30..dule.js gzip N/A 16.5 kB N/A
Overall change 189 kB 189 kB ⚠️ +50 B
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.81 kB 1.81 kB
_app.js gzip 873 B 873 B
_error.js 12 kB 12 kB
_error.js gzip 4.73 kB 4.73 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.79 kB 4.79 kB
index.js 318 B 318 B
index.js gzip 222 B 222 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.5 kB 3.5 kB
routerDirect.js 408 B 408 B
routerDirect.js gzip 281 B 281 B
withRouter.js 419 B 419 B
withRouter.js gzip 280 B 280 B
Overall change 35.8 kB 35.8 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.7 kB 1.7 kB
_app.module.js gzip 832 B 832 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.59 kB 8.59 kB
hooks.module.js 1.52 kB 1.52 kB
hooks.module.js gzip 793 B 793 B
index.module.js 294 B 294 B
index.module.js gzip 223 B 223 B
link.module.js 8.53 kB 8.53 kB
link.module.js gzip 3.68 kB 3.68 kB
routerDirect.module.js 394 B 394 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.module.js 404 B 404 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 36.1 kB 36.1 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
index.html 3.62 kB 3.62 kB
index.html gzip 946 B 946 B
link.html 3.66 kB 3.66 kB
link.html gzip 953 B 953 B
withRouter.html 3.67 kB 3.67 kB
withRouter.html gzip 941 B 941 B
Overall change 10.9 kB 10.9 kB

Diffs

Diff for main-HASH.js
@@ -490,7 +490,7 @@ function () {
   var _ref2 = (0, _asyncToGenerator2["default"])(
   /*#__PURE__*/
   _regeneratorRuntime.mark(function _callee(_temp) {
-    var _ref, passedWebpackHMR, initialErr, _require, isValidElementType, renderCtx;
+    var _ref, passedWebpackHMR, initialErr, _require, isValidElementType, initialAsPath, renderCtx;
 
     return _regeneratorRuntime.wrap(function _callee$(_context) {
       while (1) {
@@ -547,7 +547,10 @@ function () {
             return window.__NEXT_PRELOADREADY(dynamicIds);
 
           case 22:
-            exports.router = router = (0, _router.createRouter)(page, query, asPath, {
+            // if auto prerendered and dynamic route wait to update asPath
+            // until after mount to prevent hydration mismatch
+            initialAsPath = (0, _isDynamic.isDynamicRoute)(page) && data.nextExport ? page : asPath;
+            exports.router = router = (0, _router.createRouter)(page, query, initialAsPath, {
               initialProps: props,
               pageLoader: pageLoader,
               App: App,
@@ -577,7 +580,7 @@ function () {
             render(renderCtx);
             return _context.abrupt("return", emitter);
 
-          case 26:
+          case 27:
           case "end":
             return _context.stop();
         }
Diff for main-HASH.module.js
@@ -545,9 +545,12 @@ function () {
 
     if (window.__NEXT_PRELOADREADY) {
       yield window.__NEXT_PRELOADREADY(dynamicIds);
-    }
+    } // if auto prerendered and dynamic route wait to update asPath
+    // until after mount to prevent hydration mismatch
+
 
-    exports.router = router = (0, _router.createRouter)(page, query, asPath, {
+    const initialAsPath = (0, _isDynamic.isDynamicRoute)(page) && data.nextExport ? page : asPath;
+    exports.router = router = (0, _router.createRouter)(page, query, initialAsPath, {
       initialProps: props,
       pageLoader,
       App,
Diff for index.html
@@ -12,11 +12,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-65bc2484fc43d8f089ac.js"
+        <script src="/_next/static/runtime/main-aaf2a46cf6229d77a673.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
+        <script src="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -53,9 +53,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.01cc4f1e34fde13f4eb9.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.884fe048044e62151ce8.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>
Diff for link.html
@@ -14,9 +14,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -52,13 +52,13 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.01cc4f1e34fde13f4eb9.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.884fe048044e62151ce8.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-65bc2484fc43d8f089ac.js"
+        <script src="/_next/static/runtime/main-aaf2a46cf6229d77a673.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
+        <script src="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>
Diff for withRouter.html
@@ -14,9 +14,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -50,13 +50,13 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.01cc4f1e34fde13f4eb9.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.884fe048044e62151ce8.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-65bc2484fc43d8f089ac.js"
+        <script src="/_next/static/runtime/main-aaf2a46cf6229d77a673.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
+        <script src="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 17.2s 16.8s -358ms
nodeModulesSize 41.9 MB 42 MB ⚠️ +4.66 kB
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB ⚠️ +46 B
main-HASH.js gzip 6.65 kB 6.66 kB ⚠️ +11 B
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..3fa59b1f5.js 43.1 kB N/A N/A
de003c3a9d30..b1f5.js gzip 15.5 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
de003c3a9d30..1c5d17695.js N/A 43.1 kB N/A
de003c3a9d30..7695.js gzip N/A 15.4 kB N/A
Overall change 210 kB 210 kB ⚠️ +46 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.5 kB 16.6 kB ⚠️ +50 B
main-HASH.module.js gzip 6.39 kB 6.4 kB ⚠️ +11 B
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..4b.module.js 45.5 kB N/A N/A
de003c3a9d30..dule.js gzip 16.5 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
de003c3a9d30..5f.module.js N/A 45.5 kB N/A
de003c3a9d30..dule.js gzip N/A 16.5 kB N/A
Overall change 189 kB 189 kB ⚠️ +50 B
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.81 kB 1.81 kB
_app.js gzip 873 B 873 B
_error.js 12 kB 12 kB
_error.js gzip 4.73 kB 4.73 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.79 kB 4.79 kB
index.js 318 B 318 B
index.js gzip 222 B 222 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.5 kB 3.5 kB
routerDirect.js 408 B 408 B
routerDirect.js gzip 281 B 281 B
withRouter.js 419 B 419 B
withRouter.js gzip 280 B 280 B
Overall change 35.8 kB 35.8 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.7 kB 1.7 kB
_app.module.js gzip 832 B 832 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.59 kB 8.59 kB
hooks.module.js 1.52 kB 1.52 kB
hooks.module.js gzip 793 B 793 B
index.module.js 294 B 294 B
index.module.js gzip 223 B 223 B
link.module.js 8.53 kB 8.53 kB
link.module.js gzip 3.68 kB 3.68 kB
routerDirect.module.js 394 B 394 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.module.js 404 B 404 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 36.1 kB 36.1 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Serverless bundles Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_error.js 248 kB 248 kB -264 B
_error.js gzip 66.3 kB 66.2 kB -108 B
hooks.html 3.75 kB 3.75 kB
hooks.html gzip 978 B 978 B
index.js 248 kB 248 kB -264 B
index.js gzip 66.6 kB 66.5 kB -106 B
link.js 256 kB 256 kB -264 B
link.js gzip 68.6 kB 68.5 kB -101 B
routerDirect.js 249 kB 249 kB -264 B
routerDirect.js gzip 66.6 kB 66.5 kB -108 B
withRouter.js 249 kB 249 kB -264 B
withRouter.js gzip 66.7 kB 66.6 kB -107 B
Overall change 1.25 MB 1.25 MB -1.32 kB

Commit: 2aa25a5

@ijjk
Copy link
Member Author

ijjk commented Sep 16, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 15.3s 15s -264ms
nodeModulesSize 41.9 MB 42 MB ⚠️ +4.82 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB
main-HASH.js gzip 6.65 kB 6.65 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..3fa59b1f5.js 43.1 kB 43.1 kB
de003c3a9d30..b1f5.js gzip 15.5 kB 15.5 kB
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.5 kB 16.5 kB
main-HASH.module.js gzip 6.39 kB 6.39 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..4b.module.js 45.5 kB 45.5 kB
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.81 kB 1.81 kB
_app.js gzip 873 B 873 B
_error.js 12 kB 12 kB
_error.js gzip 4.73 kB 4.73 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.79 kB 4.79 kB
index.js 318 B 318 B
index.js gzip 222 B 222 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.5 kB 3.5 kB
routerDirect.js 408 B 408 B
routerDirect.js gzip 281 B 281 B
withRouter.js 419 B 419 B
withRouter.js gzip 280 B 280 B
Overall change 35.8 kB 35.8 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.7 kB 1.7 kB
_app.module.js gzip 832 B 832 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.59 kB 8.59 kB
hooks.module.js 1.52 kB 1.52 kB
hooks.module.js gzip 793 B 793 B
index.module.js 294 B 294 B
index.module.js gzip 223 B 223 B
link.module.js 8.53 kB 8.53 kB
link.module.js gzip 3.68 kB 3.68 kB
routerDirect.module.js 394 B 394 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.module.js 404 B 404 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 36.1 kB 36.1 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
index.html 3.62 kB 3.62 kB
index.html gzip 946 B 946 B
link.html 3.66 kB 3.66 kB
link.html gzip 953 B 953 B
withRouter.html 3.67 kB 3.67 kB
withRouter.html gzip 941 B 941 B
Overall change 10.9 kB 10.9 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 15.3s 15.7s ⚠️ +338ms
nodeModulesSize 41.9 MB 42 MB ⚠️ +4.82 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB
main-HASH.js gzip 6.65 kB 6.65 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..3fa59b1f5.js 43.1 kB 43.1 kB
de003c3a9d30..b1f5.js gzip 15.5 kB 15.5 kB
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.5 kB 16.5 kB
main-HASH.module.js gzip 6.39 kB 6.39 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..4b.module.js 45.5 kB 45.5 kB
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.81 kB 1.81 kB
_app.js gzip 873 B 873 B
_error.js 12 kB 12 kB
_error.js gzip 4.73 kB 4.73 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.79 kB 4.79 kB
index.js 318 B 318 B
index.js gzip 222 B 222 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.5 kB 3.5 kB
routerDirect.js 408 B 408 B
routerDirect.js gzip 281 B 281 B
withRouter.js 419 B 419 B
withRouter.js gzip 280 B 280 B
Overall change 35.8 kB 35.8 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.7 kB 1.7 kB
_app.module.js gzip 832 B 832 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.59 kB 8.59 kB
hooks.module.js 1.52 kB 1.52 kB
hooks.module.js gzip 793 B 793 B
index.module.js 294 B 294 B
index.module.js gzip 223 B 223 B
link.module.js 8.53 kB 8.53 kB
link.module.js gzip 3.68 kB 3.68 kB
routerDirect.module.js 394 B 394 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.module.js 404 B 404 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 36.1 kB 36.1 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Serverless bundles
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_error.js 248 kB 248 kB
_error.js gzip 66.3 kB 66.3 kB
hooks.html 3.75 kB 3.75 kB
hooks.html gzip 978 B 978 B
index.js 248 kB 248 kB
index.js gzip 66.6 kB 66.6 kB
link.js 256 kB 256 kB
link.js gzip 68.6 kB 68.6 kB
routerDirect.js 249 kB 249 kB
routerDirect.js gzip 66.6 kB 66.6 kB
withRouter.js 249 kB 249 kB
withRouter.js gzip 66.7 kB 66.7 kB
Overall change 1.25 MB 1.25 MB

Commit: 481d3a8

@ijjk
Copy link
Member Author

ijjk commented Sep 16, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 15.1s 16.2s ⚠️ +1.1s
nodeModulesSize 41.9 MB 42 MB ⚠️ +4.82 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB
main-HASH.js gzip 6.65 kB 6.65 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..3fa59b1f5.js 43.1 kB 43.1 kB
de003c3a9d30..b1f5.js gzip 15.5 kB 15.5 kB
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.5 kB 16.5 kB
main-HASH.module.js gzip 6.39 kB 6.39 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..4b.module.js 45.5 kB 45.5 kB
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.81 kB 1.81 kB
_app.js gzip 873 B 873 B
_error.js 12 kB 12 kB
_error.js gzip 4.73 kB 4.73 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.79 kB 4.79 kB
index.js 318 B 318 B
index.js gzip 222 B 222 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.5 kB 3.5 kB
routerDirect.js 408 B 408 B
routerDirect.js gzip 281 B 281 B
withRouter.js 419 B 419 B
withRouter.js gzip 280 B 280 B
Overall change 35.8 kB 35.8 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.7 kB 1.7 kB
_app.module.js gzip 832 B 832 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.59 kB 8.59 kB
hooks.module.js 1.52 kB 1.52 kB
hooks.module.js gzip 793 B 793 B
index.module.js 294 B 294 B
index.module.js gzip 223 B 223 B
link.module.js 8.53 kB 8.53 kB
link.module.js gzip 3.68 kB 3.68 kB
routerDirect.module.js 394 B 394 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.module.js 404 B 404 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 36.1 kB 36.1 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
index.html 3.62 kB 3.62 kB
index.html gzip 947 B 947 B
link.html 3.66 kB 3.66 kB
link.html gzip 955 B 955 B
withRouter.html 3.67 kB 3.67 kB
withRouter.html gzip 943 B 943 B
Overall change 10.9 kB 10.9 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 15.2s 15.2s -6ms
nodeModulesSize 41.9 MB 42 MB ⚠️ +4.82 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB
main-HASH.js gzip 6.65 kB 6.65 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..3fa59b1f5.js 43.1 kB 43.1 kB
de003c3a9d30..b1f5.js gzip 15.5 kB 15.5 kB
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.5 kB 16.5 kB
main-HASH.module.js gzip 6.39 kB 6.39 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..4b.module.js 45.5 kB 45.5 kB
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.81 kB 1.81 kB
_app.js gzip 873 B 873 B
_error.js 12 kB 12 kB
_error.js gzip 4.73 kB 4.73 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.79 kB 4.79 kB
index.js 318 B 318 B
index.js gzip 222 B 222 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.5 kB 3.5 kB
routerDirect.js 408 B 408 B
routerDirect.js gzip 281 B 281 B
withRouter.js 419 B 419 B
withRouter.js gzip 280 B 280 B
Overall change 35.8 kB 35.8 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.7 kB 1.7 kB
_app.module.js gzip 832 B 832 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.59 kB 8.59 kB
hooks.module.js 1.52 kB 1.52 kB
hooks.module.js gzip 793 B 793 B
index.module.js 294 B 294 B
index.module.js gzip 223 B 223 B
link.module.js 8.53 kB 8.53 kB
link.module.js gzip 3.68 kB 3.68 kB
routerDirect.module.js 394 B 394 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.module.js 404 B 404 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 36.1 kB 36.1 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Serverless bundles
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_error.js 248 kB 248 kB
_error.js gzip 66.3 kB 66.3 kB
hooks.html 3.75 kB 3.75 kB
hooks.html gzip 980 B 980 B
index.js 248 kB 248 kB
index.js gzip 66.6 kB 66.6 kB
link.js 256 kB 256 kB
link.js gzip 68.6 kB 68.6 kB
routerDirect.js 249 kB 249 kB
routerDirect.js gzip 66.6 kB 66.6 kB
withRouter.js 249 kB 249 kB
withRouter.js gzip 66.7 kB 66.7 kB
Overall change 1.25 MB 1.25 MB

Commit: fdd4738

@ijjk
Copy link
Member Author

ijjk commented Sep 16, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 13.4s 13s -385ms
nodeModulesSize 41.9 MB 42 MB ⚠️ +4.91 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB
main-HASH.js gzip 6.65 kB 6.65 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..3fa59b1f5.js 43.1 kB 43.1 kB
de003c3a9d30..b1f5.js gzip 15.5 kB 15.5 kB
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.5 kB 16.5 kB
main-HASH.module.js gzip 6.39 kB 6.39 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..4b.module.js 45.5 kB 45.5 kB
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.81 kB 1.81 kB
_app.js gzip 873 B 873 B
_error.js 12 kB 12 kB
_error.js gzip 4.73 kB 4.73 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.79 kB 4.79 kB
index.js 318 B 318 B
index.js gzip 222 B 222 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.5 kB 3.5 kB
routerDirect.js 408 B 408 B
routerDirect.js gzip 281 B 281 B
withRouter.js 419 B 419 B
withRouter.js gzip 280 B 280 B
Overall change 35.8 kB 35.8 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.7 kB 1.7 kB
_app.module.js gzip 832 B 832 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.59 kB 8.59 kB
hooks.module.js 1.52 kB 1.52 kB
hooks.module.js gzip 793 B 793 B
index.module.js 294 B 294 B
index.module.js gzip 223 B 223 B
link.module.js 8.53 kB 8.53 kB
link.module.js gzip 3.68 kB 3.68 kB
routerDirect.module.js 394 B 394 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.module.js 404 B 404 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 36.1 kB 36.1 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
index.html 3.62 kB 3.62 kB
index.html gzip 947 B 947 B
link.html 3.66 kB 3.66 kB
link.html gzip 955 B 955 B
withRouter.html 3.67 kB 3.67 kB
withRouter.html gzip 943 B 943 B
Overall change 10.9 kB 10.9 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
buildDuration 13.8s 13.8s -79ms
nodeModulesSize 41.9 MB 42 MB ⚠️ +4.91 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.js 18.2 kB 18.2 kB
main-HASH.js gzip 6.65 kB 6.65 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..3fa59b1f5.js 43.1 kB 43.1 kB
de003c3a9d30..b1f5.js gzip 15.5 kB 15.5 kB
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
main-HASH.module.js 16.5 kB 16.5 kB
main-HASH.module.js gzip 6.39 kB 6.39 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..4b.module.js 45.5 kB 45.5 kB
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.js 1.81 kB 1.81 kB
_app.js gzip 873 B 873 B
_error.js 12 kB 12 kB
_error.js gzip 4.73 kB 4.73 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.79 kB 4.79 kB
index.js 318 B 318 B
index.js gzip 222 B 222 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.5 kB 3.5 kB
routerDirect.js 408 B 408 B
routerDirect.js gzip 281 B 281 B
withRouter.js 419 B 419 B
withRouter.js gzip 280 B 280 B
Overall change 35.8 kB 35.8 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_app.module.js 1.7 kB 1.7 kB
_app.module.js gzip 832 B 832 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.59 kB 8.59 kB
hooks.module.js 1.52 kB 1.52 kB
hooks.module.js gzip 793 B 793 B
index.module.js 294 B 294 B
index.module.js gzip 223 B 223 B
link.module.js 8.53 kB 8.53 kB
link.module.js gzip 3.68 kB 3.68 kB
routerDirect.module.js 394 B 394 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.module.js 404 B 404 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 36.1 kB 36.1 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Serverless bundles
zeit/next.js canary ijjk/next.js fix/public-dynamic-priority Change
_error.js 248 kB 248 kB
_error.js gzip 66.3 kB 66.3 kB
hooks.html 3.75 kB 3.75 kB
hooks.html gzip 980 B 980 B
index.js 248 kB 248 kB
index.js gzip 66.6 kB 66.6 kB
link.js 256 kB 256 kB
link.js gzip 68.6 kB 68.6 kB
routerDirect.js 249 kB 249 kB
routerDirect.js gzip 66.6 kB 66.6 kB
withRouter.js 249 kB 249 kB
withRouter.js gzip 66.7 kB 66.7 kB
Overall change 1.25 MB 1.25 MB

Commit: d776b01

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public files aren't prioritized over dynamic routes in dev mode
4 participants