Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure requests are resolved as directories #8742

Merged
merged 2 commits into from
Sep 14, 2019
Merged

Ensure requests are resolved as directories #8742

merged 2 commits into from
Sep 14, 2019

Conversation

Timer
Copy link
Member

@Timer Timer commented Sep 14, 2019 •
edited
Loading

resolveRequest will strip down to the base directory (path.basename) if there's no trailing slash as it assumes you passed a file.

@Timer
Ensure requests are resolved as directories
d3c7720 
`resolveRequest` will strip down to baseDir if there's no trailing slash as it assumes you passed a file.
@Timer Timer added this to the 9.0.6 milestone Sep 14, 2019
ijjk
ijjk approved these changes Sep 14, 2019
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😌

@Timer Timer merged commit d031cf6 into vercel:canary Sep 14, 2019
@Timer Timer deleted the fix-resolving branch September 14, 2019 21:41
This was referenced Jun 1, 2020
Open
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@Timer @ijjk