Monkey patch next-sass and next-less
#8944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two Next.js plugins use poor webpack practices: they define plugins without resolving themselves. As a result, the resolution root is unknown by webpack and you get into package hoisting bugs. To fix this, we emulate the logic these packages should've performed themselves on a best-effort basis.
Timer
added
Upstream
|
Could you add a test for this? |
timneutkens
reviewed
Oct 3, 2019
Co-Authored-By: Tim Neutkens <[email protected]>
timneutkens
approved these changes
Oct 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two legacy Next.js plugins use poor webpack practices: they define plugins without resolving it themselves.
As a result, the resolution root is unknown by webpack and you get into package hoisting bugs.
To fix this, we emulate the logic these packages should've performed themselves on a best-effort basis.
Fixes vercel/next-plugins#543
Fixes vercel/next-plugins#541