Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with-react-toolbox example to use /public #9099

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Update with-react-toolbox example to use /public #9099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/with-react-toolbox/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ yarn
yarn dev
```

Notice that `yarn toolbox` (or `npm run toolbox`) should be rerun every time the `"reactToolbox"` configuration in `package.json` is changed, in order to update `static/theme.js` and `static/theme.css`. The `"reactToolbox"` configuration includes styling, and the list of react-toolbox components to include.
Notice that `yarn toolbox` (or `npm run toolbox`) should be rerun every time the `"reactToolbox"` configuration in `package.json` is changed, in order to update `/theme.js` and `public/theme.css`. The `"reactToolbox"` configuration includes styling, and the list of react-toolbox components to include.

## The idea behind the example

Expand Down
3 changes: 2 additions & 1 deletion examples/with-react-toolbox/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"color-primary-contrast": "var(--color-dark-contrast)",
"color-accent-contrast": "var(--color-dark-contrast)"
},
"output": "static"
"output": "public",
"javascript": "./theme.js"
}
}
4 changes: 2 additions & 2 deletions examples/with-react-toolbox/pages/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import ThemeProvider from 'react-toolbox/lib/ThemeProvider'
import theme from '../static/theme'
import theme from '../theme'
import Head from 'next/head'

import Button from 'react-toolbox/lib/button/Button'

export default () => (
<div>
<Head>
<link href='/static/theme.css' rel='stylesheet' />
<link href='/theme.css' rel='stylesheet' />
</Head>
<ThemeProvider theme={theme}>
<Button raised primary>
Expand Down
0 examples/with-react-toolbox/static/theme.css → examples/with-react-toolbox/public/theme.css
View file
Open in desktop
File renamed without changes.
0 examples/with-react-toolbox/static/theme.js → examples/with-react-toolbox/theme.js
View file
Open in desktop
File renamed without changes.