-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get(Static|Initial)Props re-running when updating query #9907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server Mode (Increase detected
|
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
buildDuration | 14.2s | 14.4s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.js gzip | 6.44 kB | 6.45 kB | |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..6ef5.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework.HASH.js gzip | 39.5 kB | 39.5 kB | ✓ |
Overall change | 69.2 kB | 69.2 kB |
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.42 kB | 5.43 kB | |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.6 kB | 12.6 kB | ✓ |
framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 63.7 kB | 63.7 kB |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.93 kB | 2.93 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.89 kB | 9.89 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.49 kB | 2.49 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.43 kB | 7.43 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
index.html gzip | 1.04 kB | 1.04 kB | |
link.html gzip | 1.04 kB | 1.04 kB | ✓ |
withRouter.html gzip | 1.03 kB | 1.03 kB | ✓ |
Overall change | 3.12 kB | 3.12 kB |
Diffs
Diff for main-HASH.js
@@ -584,6 +584,7 @@
// client-side hydration. Your app should _never_ use this property.
// It may change at any time without notice.
_h: 1,
+ shallow: true,
}
)
}
Diff for main-HASH.module.js
@@ -447,6 +447,7 @@
// client-side hydration. Your app should _never_ use this property.
// It may change at any time without notice.
_h: 1,
+ shallow: true,
}
)
}
Diff for index.html
@@ -27,7 +27,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+ href="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -121,13 +121,13 @@
type="module"
></script
><script
- src="/_next/static/runtime/main-6f2f4f6b75345eed99f5.js"
+ src="/_next/static/runtime/main-58009eb7bc610a20890d.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+ src="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -45,7 +45,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+ href="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -168,13 +168,13 @@
type="module"
></script
><script
- src="/_next/static/runtime/main-6f2f4f6b75345eed99f5.js"
+ src="/_next/static/runtime/main-58009eb7bc610a20890d.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+ src="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -45,7 +45,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+ href="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -163,13 +163,13 @@
type="module"
></script
><script
- src="/_next/static/runtime/main-6f2f4f6b75345eed99f5.js"
+ src="/_next/static/runtime/main-58009eb7bc610a20890d.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+ src="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
async=""
crossorigin="anonymous"
type="module"
Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
buildDuration | 14.7s | 14.7s | -12ms |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.js gzip | 6.44 kB | 6.45 kB | |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..6ef5.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework.HASH.js gzip | 39.5 kB | 39.5 kB | ✓ |
Overall change | 69.2 kB | 69.2 kB |
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.42 kB | 5.43 kB | |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.6 kB | 12.6 kB | ✓ |
framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 63.7 kB | 63.7 kB |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.93 kB | 2.93 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.89 kB | 9.89 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.49 kB | 2.49 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.43 kB | 7.43 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_error.js gzip | 78.9 kB | 78.9 kB | |
hooks.html gzip | 1.07 kB | 1.07 kB | ✓ |
index.js gzip | 79.1 kB | 79.1 kB | |
link.js gzip | 81.3 kB | 81.3 kB | |
routerDirect.js gzip | 79.2 kB | 79.2 kB | |
withRouter.js gzip | 79.3 kB | 79.3 kB | |
Overall change | 399 kB | 399 kB |
Commit: 5822d27
Stats from current PRDefault Server Mode (Increase detected
|
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
buildDuration | 13.4s | 12.9s | -474ms |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.js gzip | 6.44 kB | 6.45 kB | |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..6ef5.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework.HASH.js gzip | 39.5 kB | 39.5 kB | ✓ |
Overall change | 69.2 kB | 69.2 kB |
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.42 kB | 5.43 kB | |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.6 kB | 12.6 kB | ✓ |
framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 63.7 kB | 63.7 kB |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.93 kB | 2.93 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.89 kB | 9.89 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.49 kB | 2.49 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.43 kB | 7.43 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
index.html gzip | 1.04 kB | 1.04 kB | |
link.html gzip | 1.04 kB | 1.04 kB | ✓ |
withRouter.html gzip | 1.03 kB | 1.03 kB | ✓ |
Overall change | 3.12 kB | 3.12 kB |
Diffs
Diff for main-HASH.js
@@ -584,6 +584,7 @@
// client-side hydration. Your app should _never_ use this property.
// It may change at any time without notice.
_h: 1,
+ shallow: true,
}
)
}
Diff for main-HASH.module.js
@@ -447,6 +447,7 @@
// client-side hydration. Your app should _never_ use this property.
// It may change at any time without notice.
_h: 1,
+ shallow: true,
}
)
}
Diff for index.html
@@ -27,7 +27,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+ href="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -121,13 +121,13 @@
type="module"
></script
><script
- src="/_next/static/runtime/main-6f2f4f6b75345eed99f5.js"
+ src="/_next/static/runtime/main-58009eb7bc610a20890d.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+ src="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -45,7 +45,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+ href="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -168,13 +168,13 @@
type="module"
></script
><script
- src="/_next/static/runtime/main-6f2f4f6b75345eed99f5.js"
+ src="/_next/static/runtime/main-58009eb7bc610a20890d.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+ src="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -45,7 +45,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+ href="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -163,13 +163,13 @@
type="module"
></script
><script
- src="/_next/static/runtime/main-6f2f4f6b75345eed99f5.js"
+ src="/_next/static/runtime/main-58009eb7bc610a20890d.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+ src="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
async=""
crossorigin="anonymous"
type="module"
Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
buildDuration | 13.6s | 13.8s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.js gzip | 6.44 kB | 6.45 kB | |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..6ef5.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework.HASH.js gzip | 39.5 kB | 39.5 kB | ✓ |
Overall change | 69.2 kB | 69.2 kB |
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.42 kB | 5.43 kB | |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.6 kB | 12.6 kB | ✓ |
framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 63.7 kB | 63.7 kB |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.93 kB | 2.93 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.89 kB | 9.89 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.49 kB | 2.49 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.43 kB | 7.43 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_error.js gzip | 78.9 kB | 78.9 kB | |
hooks.html gzip | 1.07 kB | 1.07 kB | ✓ |
index.js gzip | 79.1 kB | 79.1 kB | |
link.js gzip | 81.3 kB | 81.3 kB | |
routerDirect.js gzip | 79.2 kB | 79.2 kB | |
withRouter.js gzip | 79.3 kB | 79.3 kB | |
Overall change | 399 kB | 399 kB |
Commit: b1d12fd
Timer
requested changes
Jan 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
holding for 9.2
Timer
approved these changes
Jan 3, 2020
Stats from current PRDefault Server Mode (Increase detected
|
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
buildDuration | 12.3s | 12.2s | -123ms |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.js gzip | 6.43 kB | 6.44 kB | |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..6ef5.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework.HASH.js gzip | 39.5 kB | 39.5 kB | ✓ |
Overall change | 69.2 kB | 69.2 kB |
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.41 kB | 5.42 kB | |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.6 kB | 12.6 kB | ✓ |
framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 63.7 kB | 63.7 kB |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.93 kB | 2.93 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.89 kB | 9.89 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.49 kB | 2.49 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.43 kB | 7.43 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
index.html gzip | 1.04 kB | 1.04 kB | ✓ |
link.html gzip | 1.04 kB | 1.04 kB | |
withRouter.html gzip | 1.03 kB | 1.03 kB | ✓ |
Overall change | 3.11 kB | 3.11 kB |
Diffs
Diff for main-HASH.js
@@ -584,6 +584,7 @@
// client-side hydration. Your app should _never_ use this property.
// It may change at any time without notice.
_h: 1,
+ shallow: true,
}
)
}
Diff for main-HASH.module.js
@@ -447,6 +447,7 @@
// client-side hydration. Your app should _never_ use this property.
// It may change at any time without notice.
_h: 1,
+ shallow: true,
}
)
}
Diff for index.html
@@ -45,7 +45,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+ href="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -163,13 +163,13 @@
type="module"
></script
><script
- src="/_next/static/runtime/main-b984e7fb60832e00613e.js"
+ src="/_next/static/runtime/main-263cdc7d791b720e46ce.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+ src="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -45,7 +45,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+ href="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -168,13 +168,13 @@
type="module"
></script
><script
- src="/_next/static/runtime/main-b984e7fb60832e00613e.js"
+ src="/_next/static/runtime/main-263cdc7d791b720e46ce.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+ src="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -45,7 +45,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+ href="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -163,13 +163,13 @@
type="module"
></script
><script
- src="/_next/static/runtime/main-b984e7fb60832e00613e.js"
+ src="/_next/static/runtime/main-263cdc7d791b720e46ce.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+ src="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
async=""
crossorigin="anonymous"
type="module"
Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
buildDuration | 12.7s | 12.8s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.js gzip | 6.43 kB | 6.44 kB | |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..6ef5.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework.HASH.js gzip | 39.5 kB | 39.5 kB | ✓ |
Overall change | 69.2 kB | 69.2 kB |
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.41 kB | 5.42 kB | |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.6 kB | 12.6 kB | ✓ |
framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 63.7 kB | 63.7 kB |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.93 kB | 2.93 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.89 kB | 9.89 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.49 kB | 2.49 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.43 kB | 7.43 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_error.js gzip | 78.9 kB | 78.9 kB | -2 B |
hooks.html gzip | 1.07 kB | 1.07 kB | ✓ |
index.js gzip | 79.1 kB | 79.1 kB | -2 B |
link.js gzip | 81.3 kB | 81.3 kB | -1 B |
routerDirect.js gzip | 79.2 kB | 79.2 kB | -2 B |
withRouter.js gzip | 79.3 kB | 79.3 kB | -2 B |
Overall change | 399 kB | 399 kB | -9 B |
Commit: c5e36fc
Stats from current PRDefault Server Mode (Increase detected
|
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
buildDuration | 13.8s | 13.7s | -140ms |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.js gzip | 6.43 kB | 6.44 kB | |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..6ef5.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework.HASH.js gzip | 39.5 kB | 39.5 kB | ✓ |
Overall change | 69.2 kB | 69.2 kB |
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.41 kB | 5.42 kB | |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.6 kB | 12.6 kB | ✓ |
framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 63.7 kB | 63.7 kB |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.93 kB | 2.93 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.89 kB | 9.89 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.49 kB | 2.49 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.43 kB | 7.43 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
index.html gzip | 1.04 kB | 1.04 kB | ✓ |
link.html gzip | 1.04 kB | 1.04 kB | |
withRouter.html gzip | 1.03 kB | 1.03 kB | ✓ |
Overall change | 3.11 kB | 3.11 kB |
Diffs
Diff for main-HASH.js
@@ -584,6 +584,7 @@
// client-side hydration. Your app should _never_ use this property.
// It may change at any time without notice.
_h: 1,
+ shallow: true,
}
)
}
Diff for main-HASH.module.js
@@ -447,6 +447,7 @@
// client-side hydration. Your app should _never_ use this property.
// It may change at any time without notice.
_h: 1,
+ shallow: true,
}
)
}
Diff for index.html
@@ -45,7 +45,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+ href="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -163,13 +163,13 @@
type="module"
></script
><script
- src="/_next/static/runtime/main-b984e7fb60832e00613e.js"
+ src="/_next/static/runtime/main-263cdc7d791b720e46ce.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+ src="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -45,7 +45,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+ href="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -168,13 +168,13 @@
type="module"
></script
><script
- src="/_next/static/runtime/main-b984e7fb60832e00613e.js"
+ src="/_next/static/runtime/main-263cdc7d791b720e46ce.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+ src="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -45,7 +45,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+ href="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -163,13 +163,13 @@
type="module"
></script
><script
- src="/_next/static/runtime/main-b984e7fb60832e00613e.js"
+ src="/_next/static/runtime/main-263cdc7d791b720e46ce.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+ src="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
async=""
crossorigin="anonymous"
type="module"
Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
buildDuration | 14.8s | 14.2s | -533ms |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.js gzip | 6.43 kB | 6.44 kB | |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..6ef5.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework.HASH.js gzip | 39.5 kB | 39.5 kB | ✓ |
Overall change | 69.2 kB | 69.2 kB |
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.41 kB | 5.42 kB | |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.6 kB | 12.6 kB | ✓ |
framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 63.7 kB | 63.7 kB |
Legacy Client Bundles (polyfills)
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.93 kB | 2.93 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.89 kB | 9.89 kB | ✓ |
Client Pages Modern
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.49 kB | 2.49 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.43 kB | 7.43 kB | ✓ |
Client Build Manifests
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
zeit/next.js canary | ijjk/next.js update/updating-query | Change | |
---|---|---|---|
_error.js gzip | 78.9 kB | 78.9 kB | -2 B |
hooks.html gzip | 1.07 kB | 1.07 kB | ✓ |
index.js gzip | 79.1 kB | 79.1 kB | -2 B |
link.js gzip | 81.3 kB | 81.3 kB | -1 B |
routerDirect.js gzip | 79.2 kB | 79.2 kB | -2 B |
withRouter.js gzip | 79.3 kB | 79.3 kB | -2 B |
Overall change | 399 kB | 399 kB | -9 B |
Commit: 4bdcc62
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure to use
shallow: true
when updating the query for static pages so that we don't re-callgetInitialProps
orgetStaticProps
. Also, adds a test to make sure we don't regress on thisFixes: #9902