-
Notifications
You must be signed in to change notification settings - Fork 136
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(analyze): node-gyp-build not including zeromq prebuilds (#392)
- Fixes #391 Three things I want to point out: 1. In zeromq the way node-gyp-build is called is by passing `path.join(__dirname, "..")` instead of `__dirname` to the `require("node-gyp-build")(...)` call. 2. In zeromq they use `@aminya/node-gyp-build` instead of `node-gyp-build`, particular-li version `4.5.0-aminya.5`. 3. The zeromq version that's recommended for new project is the `6` which is beta according to @aminya https://github.com/zeromq/zeromq.js. After those changes it resolves OK. ``` ❯ node ./node_modules/@vercel/nft/out/cli.js print ./node_modules/zeromq/lib/index.js FILELIST: node_modules/@aminya/node-gyp-build/index.js node_modules/@aminya/node-gyp-build/package.json node_modules/zeromq/lib/draft.js node_modules/zeromq/lib/index.js node_modules/zeromq/lib/native.js node_modules/zeromq/lib/util.js node_modules/zeromq/package.json node_modules/zeromq/prebuilds/darwin-x64/node.napi.glibc.node <---- It worked! ``` --------- Co-authored-by: Steven <[email protected]>
- Loading branch information
Showing
7 changed files
with
167 additions
and
17 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
const zmq = require("zeromq"); | ||
const sock = new zmq.Push; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
const zeromq = require('zeromq'); | ||
const sock = new zmq.Push; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
[ | ||
"node_modules/@aminya/node-gyp-build/index.js", | ||
"node_modules/@aminya/node-gyp-build/package.json", | ||
"node_modules/zeromq/lib/draft.js", | ||
"node_modules/zeromq/lib/index.js", | ||
"node_modules/zeromq/lib/native.js", | ||
"node_modules/zeromq/lib/util.js", | ||
"node_modules/zeromq/package.json", | ||
"package.json", | ||
"test/unit/zeromq-node-gyp/input.js" | ||
] |