Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

Add cross-platform support for dot-node files #1066

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Add cross-platform support for dot-node files #1066

merged 3 commits into from
Mar 19, 2021

Conversation

david-mohr
Copy link
Contributor

Here's my attempt at cross-platform support for node files.

  • It will try to automatically download node files using prebuild-install
  • Where that's not available, one can also manually add the pre-compiled node files using the .${platform} file extension

This is an addon to #837.

@david-mohr david-mohr mentioned this pull request Mar 19, 2021
Closed
@leerob
Copy link
Member

leerob commented Mar 19, 2021

Could you take a look at the failing tests?

@david-mohr
Copy link
Contributor Author

@leerob yep, working on it

@david-mohr
Copy link
Contributor Author

@leerob done, tests now pass

leerob
leerob approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you. I will try to release again.

@leerob leerob merged commit 3b947c8 into vercel:master Mar 19, 2021
@pkeuter pkeuter mentioned this pull request Mar 23, 2021
Closed
@liranmauda liranmauda mentioned this pull request May 10, 2021
Closed
@robertsLando robertsLando mentioned this pull request Oct 12, 2021
Merged
@CMCDragonkai CMCDragonkai mentioned this pull request May 10, 2022
Closed
17 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-mohr @leerob