better sanitize modules path #1103
Conversation
|
@JeffJassky Try again and let me know |
prelude/bootstrap.js
Outdated
| @@ -1243,7 +1243,8 @@ function payloadFileSync(pointer) { | |||
| } | |||
|
|
|||
| function revertMakingLong(f) { | |||
| if (/^\\\\\?\\/.test(f)) return f.slice(4); | |||
| const prefixRegex = /^\\\\\?[\\]+/ | |||
There was a problem hiding this comment.
May be prefixRegex could be put in global scope to spare the time to construct the Regexp machinery each time.
There was a problem hiding this comment.
Or I could make it part of the function
|
I just checked fresh installs of the latest 4.5.1 on both Mac and Linux and had modules loaded successfully on both. I got it working on local machines as well as for CI/CD with Github actions. As it turns out this PR may not be necessary unless others can reproduce the module path issue I was seeing before. |
|
@JeffJassky Ok so should I close this PR so? |
|
It seems that way, yes. If the issue resurfaces I'll add details to #1075. |
|
IMO we could merge this as it removes a repeated pattern and makes the regex more strics. Thoughts @jesec @hipstersmoothie @erossignon ? |
|
My preference is to leave this as is because it's not broken. If it does turn out to be an issue, then we could re-open and merge. I like to err on the side of caution. |
|
This pull-request is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this pull-request entirely you can add the no-stale label |
|
This pull-request is now closed due to inactivity, you can of course reopen or reference this pull-request if you see fit. |
Fixes #1075