-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Included tests for verifying SSL hosting #720
Conversation
Add support for PFX or PKCS12 encoded certificates
Updated cli snapshot due to change in help test, using vitest -u option
Added tests for SSL hosting with PFX and PEM certificates
Can the CI be approved so that I can verify if its working on the ubuntu host as well? My dev box is Windows. |
This is awesome - excellent work! |
Since we have GitHub Actions now running smooth, do we want to disconnect CircleCI from this repo? https://app.circleci.com/pipelines/github/vercel/serve Let me know if an issue should be raised for the same? |
Thanks @gamemaker1 For the feedback, address all your comments. |
Okay, CircleCI should hopefully be removed now. |
All checks are passing fine, do you have any other feedback for me on this PR? If not, I would say its ready to be merged. |
Looks good to me :] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
Added tests for SSL hosting with PFX and PEM certificates.
Builds on #708 feature to test new scenarios
CC: @leerob