Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo: suspense demo #105

Merged
merged 3 commits into from
Nov 10, 2019
Merged

demo: suspense demo #105

merged 3 commits into from
Nov 10, 2019

Conversation

wzhudev
Copy link
Contributor

@wzhudev wzhudev commented Nov 9, 2019

close #90

This pull request adds a Suspense example.

With <Suspense>:

Snipaste_2019-11-09_16-22-51

With <ErrorBoundary>, when the application fails to get response (e.g the user is offline):

Snipaste_2019-11-09_16-19-57

@wzhudev
Copy link
Contributor Author

wzhudev commented Nov 9, 2019

Still, I cannot get the demo running if swr is resolved by link:../... @quietshu

@shuding
Copy link
Member

shuding commented Nov 9, 2019

Thank you @wendzhue!

We're currently using the package for examples (not link:../.. anymore), so they can be standalone projects. And also yarn.lock can be removed as well (it'll be cleaner) : )

@shuding
Copy link
Member

shuding commented Nov 10, 2019

Can you add react and react-dom to dependencies as well?

@wzhudev
Copy link
Contributor Author

wzhudev commented Nov 10, 2019

Can you add react and react-dom to dependencies as well?

Sure.

shuding
shuding approved these changes Nov 10, 2019
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shuding shuding merged commit 3019306 into vercel:master Nov 10, 2019
@wzhudev wzhudev deleted the suspense-demo branch November 11, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiodxa sergiodxa sergiodxa left review comments

@shuding shuding shuding approved these changes

@pacocoursey pacocoursey Awaiting requested review from pacocoursey

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example for Suspense
3 participants
@wzhudev @shuding @sergiodxa