Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta] Fix bound mutate not using latest key #1383

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

shuding
Copy link
Member

@shuding shuding commented Aug 26, 2021

This was my mistake (wanted to optimize the code), obviously the inlined useCallback will not create a closure to reference to the latest key ref. This PR reverts it back to the current (0.x) implementation and adds a test for it.

@shuding shuding requested a review from huozhi as a code owner August 26, 2021 21:01
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d3d1259:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@shuding shuding merged commit 1dcff75 into master Aug 26, 2021
@shuding shuding deleted the fix-bound-mutate branch August 26, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants