test: recognize type definition for screen of testing-library/react #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7657734:
|
koba04
force-pushed
the
update-test-deps
branch
from
da2dd7c
to
7657734
Compare
|
Duplicate tests have been removed via #914, so this is now ready for review. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
screenisn't recognized because@types/testing-library__reactdoesn't have the type definition.jestdoesn't raise the error becausediagnosticsofts-jestis disabled.This can be fixed by updating
@testing-library/reactto v10 and I've enabled thediagnosticsagain.But it causes another problem caused by a breaking change of
@testing-library/domv7.To fix this, I've updated
jestpackages to v25, which includes MutationObserver.Unfortunatelly, some tests in
use-swr-test.tsxare still failed. I can fix these tests, but they have already been fixed in separated files at #901.I assume this PR would pass CI after #881 and #896 have been merged and removed duplicate tests.