-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbo crashes #9016
Comments
Same but in different OS
|
Same issue here with turbo 2.0.14 and no experimental rules. Happens on Dev server after saving a modified file, yet just sometimes (always the same file). Could not find a pattern which kind of change causes this to happen. |
Same here
|
Disabling tui seems to stop the crashing |
Also on Windows 11 |
I'm getting this too:
|
This should be fixed in |
### Description As #9016 displayed, panicking in the render thread leads to a very poor user experience. We should do our best effort to avoid this by using errors so we can make sure the `cleanup` code gets run. This PR removes (almost) all `unwrap`s/`expect`s in favor of returning an `Err` which will cause us to exit `run_app_inner`. ### Testing Instructions Existing unit tests. 👀
Verify canary release
Link to code that reproduces this issue
cannot provide as I don't know what causes the problem
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Windows
Which canary version will you have in your reproduction?
2.0.13-canary.1
Describe the Bug
It once crashed saying "could not connect to UI thread" logging this file:
And crashed again another time saying something else I can't remember and logged this file:
It does run the project without change sometimes and randomly crashes again. So I assume it's not the code's fault.
UPDATE: The second error message is
internal errors encountered: receiver dropped
and occurs when saving with the watcher on. Sorry for the vague explanation and not providing an example but I thought it's better I at least report this. I suspect this is a bug in the watcher. I use turbo watch (and not tsc watch).Expected Behavior
To Reproduce
Additional context
I use these experimental Next config options:
The text was updated successfully, but these errors were encountered: