Support yarn not installed in create-turbo
#255
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/HckpLZGpeL4MLfv6CMiJbeBqfj9U |
seanyusa
changed the title
create-turbo support yarn not installed
create-turbo/src/yarn.ts
Outdated
| @@ -0,0 +1,10 @@ | |||
| import { execSync } from "child_process"; | |||
|
|
|||
| export function checkIfYarnInstalled(): boolean { | |||
There was a problem hiding this comment.
Can we reuse create-turbo/src/shouldUseYarn.ts?
There was a problem hiding this comment.
@jaredpalmer Ah yes, it's perfect! I didn't look into what the userAgent was, and I thought that was checking for something else, learned about a new value today!
Thoughts on renaming shouldUseYarn? Reads a bit to me like "are we supposed to use yarn", as opposed to checking if yarn is running/available, which is partially why I didn't look more closely at it in the first place.
|
Updated! Thanks for reviewing! |
jaredpalmer
changed the title
create-turbo support yarn not installedcreate-turbo
Closes #241
Disable the yarn option if not installed.
Before
After
Note
There is one "valid" path that this prevents. ("valid" as in path that currently works)
That path is:
yarn install?"This path works because we don't have to execute
yarn installon behalf of the user. Is this a case we want to keep? If so, then we will need to force "No" for the next question instead and log thatyarn installwas not run becauseyarnitself is not installed.